Fix FakeRedisMixin.from_url for unix sockets

Joerg Herbel · Joerg Herbel · commit c1017c488166 · 2021-08-27T08:27:42.000+02:00
fakeredis.FakeRedisMixin.from_url is broken for unix sockets. fakeredis.FakeRedis.from_url("unix://a/b/c") results in TypeError: __init__() got an unexpected keyword argument 'path' This was caused by PR jamesls#304.
diff --git a/fakeredis/_server.py b/fakeredis/_server.py
@@ -2804,6 +2804,9 @@ def from_url(cls, url, db=None, **kwargs):
         pool = self.connection_pool
         pool.connection_class = FakeConnection
         pool.connection_kwargs['server'] = server
+        # FakeConnection cannot handle the path kwarg (present when from_url
+        # is called with a unix socket)
+        pool.connection_kwargs.pop('path', None)
         return self
 
 
diff --git a/test/test_fakeredis.py b/test/test_fakeredis.py
@@ -5048,6 +5048,11 @@ def test_repr(self):
         rep = repr(db)
         assert 'db=11' in rep
 
+    def test_from_unix_socket(self):
+        db = fakeredis.FakeStrictRedis.from_url('unix://a/b/c')
+        db.set('foo', 'bar')
+        assert db.get('foo') == b'bar'
+
 
 @pytest.mark.disconnected
 @fake_only
