Fix broken angle calculation with negative epsilon numbers #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating
Cos(-epsilon)
orSin(-epsilon)
, the result is incorrect.The behavior is due to
WrapAngle(-epsilon)
returns exactly360
degrees,and
int iQuadrant = int(360.0/90.0); // iQuadrant == 4
, which is actually a quadrant with index0
. So this operation must be wrapped around to produce stable results. Otherwise, index4
is reading past the end of corresponding array.