Skip to content

v3.0.0 hardwired styling #76

Closed
Closed
@moonbeetle

Description

@moonbeetle

Hey,

I'm test driving v3.0.0. It requires some getting used to after v2.5. Some things are easier now, others seem a bit more complicated. What I did notice is that some components have styling hardwired, which has a good chance of needing to be overruled. E.g. the color of a modal close button. Right now it is hardcoded in _modals.scss. If you want to change it you either have to change _modals.scss or preferably overrule it in _custom.scss.

.modal-close {
color: white;
}

Why not use color: inherit; ?
Or not define a color at all.

Another example (a form nested in a modal, I know, I just wanted to test it). I kept wondering why my first form input field had no spacing with the next. Then I saw why:

.modal-body {
p { margin-bottom: 0; }
p + p { margin-bottom: unitSize(3, -4); }
}

I just want to try to avoid as much as possible overruling CSS styles. It's not Bootstrap, right ;-)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions