-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node and hyperedge labels in the plotting functions #234
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! Just left a couple of comments/questions, nothing major.
See #233.
I think it's good for now! |
Great idea, thanks Martina! |
In the notebook I only show how to use |
Okay got it, because of potentially too many labels. I'd say in small SCs it might be useful to see them. In big ones with larger orders not really, but then the user can turn the labels off. In any case, we're plotting only the maximal simplices, right @iaciac ? And the option to show their labels might helpful to the user. |
Yes, we are plotting only the maximal order.. okay I will implement it as well then and come back to u |
Added! However, it is less intuitive than for hypergraph because now if you pass a dictionary you don't know a priori which one will be the keys kept by the drawing function.. More specifically, with |
Nice! And great point. Maybe add a note about this in the docstring? And then good to go I'd say. I'm already approving, feel free to merge when good for you. |
…ain order; update docstrings of draw_xgi_simplices
Merged! 🎉 Grazie @mcontisc |
draw_node_labels
anddraw_hyperedge_labels
.Tutorial 5 - Plotting.ipynb
to show the new functionalities. I also added an example to show how to plot a hypergraph with only hyperedges of a certain order..items()
function for NodeStat and EdgeStat.node_labels
andhyperedge_labels
because I think the raised errors (from python) are already explicative. Let me know if I should improve them.