Skip to content

Simplicial Synchronization #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nwlandry merged 11 commits into from
Nov 11, 2022
Merged

Simplicial Synchronization #212

nwlandry merged 11 commits into from
Nov 11, 2022

Conversation

@Marconurisso
Copy link
Contributor

@Marconurisso Marconurisso commented Nov 7, 2022 •
edited
Loading

  • Added functions to build boundary matrices and Hodge Laplacians for oriented simplicial complexes. The orientation is implemented as a dictionary associating to each simplex ID a boolean value: 0 for the orientation coherent with the node ordering in the object and 1 for the opposite one.
  • Added functions to simulate the simplicial Kuramoto model and compute its order parameter.
  • Modified the _subfaces method to allow it to compute only the adjacent subfaces.
  • Added some tests and an example notebook.
  • Added the new synchronization functions to the documentation.

@Marconurisso
Added functions for building the boundary matrices of an oriented sim…
daa0b72 
…plicial complex.

Added functions to simulate the simplicial Kuramoto model and compute its order parameter.
@Marconurisso
Ensured function consistency with xgi package
51ea93b
@Marconurisso
Changed _subfaces method in simplicialcomplex class
bb09788
@Marconurisso
Merge branch 'hodge_sync' of https://github.com/Marconurisso/xgi into…
86080de 
… hodge_sync
@Marconurisso
Ran black and isort
392832d
@Marconurisso
Changed variable names "skeleton" to "simplices".
aee9b0b 
Corrected subfaces orientation in boundary_matrix function.
Added tests for boundary_matrix and simulate_simplicial_kuramoto.
@Marconurisso
Added new synchronization functions to the documentation.
69ac381 
Added references to boundary matrix and simplicial kuramoto functions.
Added an example notebook for the simplicial kuramoto.
@Marconurisso
Added example notebook for the simplicial Kuramoto.
cedc0ef
@review-notebook-app
Copy link

review-notebook-app bot commented Nov 7, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

maximelucas
maximelucas reviewed Nov 7, 2022
View reviewed changes
maximelucas
maximelucas reviewed Nov 7, 2022
View reviewed changes
leotrs
leotrs reviewed Nov 8, 2022
View reviewed changes
@Marconurisso
Completed documentation for simulate_simplicial_kuramoto and _subfaces.
64937d1 
Changed the reference orientation of a simplex to be the sorting of its nodes.
leotrs
leotrs approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Marconurisso for your first contribution! 🎉 I left one more comment, but am approving now.

@leotrs
Copy link
Collaborator

leotrs commented Nov 11, 2022

Perfect! feel free to merge when ready.

@nwlandry nwlandry merged commit 4401c55 into xgi-org:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leotrs leotrs leotrs approved these changes

@maximelucas maximelucas maximelucas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Marconurisso @leotrs @maximelucas @nwlandry