Partial speed-up for draw function #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
leotrs
reviewed
Nov 5, 2022
Collaborator
leotrs
left a comment
leotrs
left a comment
There was a problem hiding this comment.
Thanks for PRing! Just a quick suggestion.
Co-authored-by: Leo Torres <[email protected]>
Co-authored-by: Iacopo Iacopini <[email protected]>
leotrs
approved these changes
Nov 5, 2022
maximelucas
reviewed
Nov 7, 2022
Collaborator
|
Thank Iac. Just put a commented related to #181 but already approved. |
maximelucas
approved these changes
Nov 7, 2022
Collaborator
|
@iaciac can you give a comparison on the speed of drawing nodes before and after your PR? |
Collaborator
Author
|
If I remember correctly it's 3 times faster. I need to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes are now plotted with iterables.
The plotting of hyperedges has to be improved, but it is not as straightforward.