Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge edges #210

Merged
merged 13 commits into from
Nov 16, 2022
Merged

Merge edges #210

merged 13 commits into from
Nov 16, 2022

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Nov 3, 2022

Partially addressing #163.

leotrs
leotrs requested changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just some minor comments.

And a question: I think we had discussed at some point refactoring the output of H.duplicate_edges once this was implemented. Or am I remembering incorrectly?

xgi/classes/hypergraph.py Outdated Show resolved Hide resolved
xgi/classes/hypergraph.py Outdated Show resolved Hide resolved
xgi/classes/hypergraph.py Outdated Show resolved Hide resolved
xgi/classes/hypergraph.py Outdated Show resolved Hide resolved
tests/classes/test_hypergraph.py Outdated Show resolved Hide resolved
maximelucas
maximelucas reviewed Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@maximelucas maximelucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Nicho, thanks.

Adding an "intersection" merge_rule could also make sense to me. For each set of merging nodes, set the attribute "color" to "red" if all merging nodes are red, otherwise discard the color attribute.

xgi/classes/hypergraph.py Outdated Show resolved Hide resolved
xgi/classes/hypergraph.py Show resolved Hide resolved
@nwlandry
Copy link
Collaborator Author

Nice Nicho, thanks.

Adding an "intersection" merge_rule could also make sense to me. For each set of merging nodes, set the attribute "color" to "red" if all merging nodes are red, otherwise discard the color attribute.

I like this idea and am working on it now!

leotrs
leotrs reviewed Nov 16, 2022
View reviewed changes
xgi/stats/__init__.py Outdated Show resolved Hide resolved
@leotrs
Copy link
Collaborator

leotrs commented Nov 16, 2022

Thanks!

@nwlandry nwlandry merged commit 8113d5a into main Nov 16, 2022
@nwlandry nwlandry deleted the merge-edges branch November 16, 2022 14:35
@maximelucas maximelucas mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leotrs leotrs leotrs approved these changes

@maximelucas maximelucas maximelucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwlandry @leotrs @maximelucas