Skip to content

Conversation

@nwlandry
Copy link
Collaborator

Attempted to make xgi.draw() a bit faster.

Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do you know how much faster this is?

@nwlandry
Copy link
Collaborator Author

nwlandry commented Sep 21, 2022

Out of curiosity, do you know how much faster this is?

Tested on the email-enron dataset (after cleanup() with default arguments) for the edges and the size EdgeStat:
_color_arg_to_dict (old): 3.08 s ± 290 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
_color_arg_to_dict (new): 119 ms ± 9.86 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
_scalar_arg_to_dict (old): 2.74 s ± 294 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
_scalar_arg_to_dict (new): 3.19 ms ± 74.5 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

@nwlandry nwlandry merged commit c262f40 into main Sep 21, 2022
@nwlandry nwlandry deleted the speedup-drawing branch September 21, 2022 15:58
@leotrs
Copy link
Collaborator

leotrs commented Sep 21, 2022

So a 1000x speedup???? Jeez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants