Cleanup hypergraph methods #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction.py. The reason is that it was causing aboslute/relative import issues
… was causing problems during CI (in particular, the output was NodeView(('b', 'a')) instead of NodeView(('a', 'b')). Instead, that particular test was moved to the actual test suite.
nwlandry
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final PR regarding #94 .
Hypergraph.has_edgehas becomeIDView.lookup.Hypergraph.duplicate_edgeshas been becomeIDView.duplicates.utilities.convert_labels_to_integertofunction.convert_labels_to_integerdue to relative import weirdness.IDViewbehaves like a list when coercing it to bool (for example we can doif view: ..., andviewwill evaluate toFalseif it is empty). This was already implemented, but I added a test for it.Closes #94.
Closes #93.