Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filterby() accept NodeStat and EdgeStat objects #144

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Make filterby() accept NodeStat and EdgeStat objects #144

merged 2 commits into from
Jul 28, 2022

Conversation

leotrs
Copy link
Collaborator

@leotrs leotrs commented Jul 28, 2022

Previously, it only accepted strings that were the name of valid NodeStat or EdgeStat, so this is a minor change.

Also fixed a bug in how the order of an edge was being computed.

Also added docs.

Fixes #135

nwlandry
nwlandry approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@nwlandry nwlandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@leotrs leotrs merged commit 518a67d into main Jul 28, 2022
@leotrs leotrs deleted the fix-135 branch July 28, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwlandry nwlandry nwlandry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot filterby using a nodestat
2 participants
@leotrs @nwlandry