Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to draw NodeStats and EdgeStats #143

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Added ability to draw NodeStats and EdgeStats #143

merged 10 commits into from
Jul 28, 2022

Conversation

nwlandry
Copy link
Collaborator

Users can now specify NodeStats or EdgeStats as drawing parameters in addition to specifying them directly with a single value, an iterable or a dictionary. Also fixed CEC_centrality so that it outputs a dict of floats, not a dict of 1D numpy arrays.

leotrs
leotrs reviewed Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! We really need to figure out how to test plotting tho...

xgi/drawing/xgi_pylab.py Outdated Show resolved Hide resolved
xgi/drawing/xgi_pylab.py Outdated Show resolved Hide resolved
@maximelucas
Copy link
Collaborator

All in all great, just lots of small detail questions!

@nwlandry nwlandry merged commit e4a330a into main Jul 28, 2022
@nwlandry nwlandry deleted the draw-stats branch July 28, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximelucas maximelucas maximelucas left review comments

@leotrs leotrs leotrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwlandry @maximelucas @leotrs