Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add max_order to xgi.draw() #186

Closed
maximelucas opened this issue Oct 3, 2022 · 5 comments
Closed

add max_order to xgi.draw() #186

maximelucas opened this issue Oct 3, 2022 · 5 comments
Labels
new feature New feature or request

Comments

@maximelucas
Copy link
Collaborator

For efficiency when not needing to see large groups.

@maximelucas maximelucas added the new feature New feature or request label Oct 3, 2022
@leotrs
Copy link
Collaborator

leotrs commented Oct 4, 2022

I wonder if this is overlapping with #182

@maximelucas
Copy link
Collaborator Author

In some cases #182 will remove the need for this one, I agree, but not in general in my mind.
You might need to work and compute measures including large orders (from a dataset or generative model) but be okay not visualising them all the time.

Actually in the past I had a function to visualise only one size of groups at a time (say triangles). That would be an extension of the present issue.

@leotrs
Copy link
Collaborator

leotrs commented Oct 4, 2022

Agreed! I think we need to implement both so that we can have xgi.draw(H, max_order=d) and xgi.draw would call H.cutoff_edges(max_order=d) at some point (or whatever other method gets rid of the higher order edges).

@leotrs
Copy link
Collaborator

leotrs commented Oct 4, 2022

This is to say I'd implement #182 first before implementing this one.

@maximelucas
Copy link
Collaborator Author

Agreed too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants