refactor: Improve npm command logging and settings initialization

CoderGamester · CoderGamester · commit cb4b03c1c96d · 2025-05-27T21:59:07.000+03:00
diff --git a/Editor/UnityBridge/McpUnityEditorWindow.cs b/Editor/UnityBridge/McpUnityEditorWindow.cs
@@ -143,16 +143,6 @@ private void DrawServerTab()
             
             EditorGUILayout.Space();
 
-            // NPM Executable Path
-            string newNpmPath = EditorGUILayout.TextField(new GUIContent("NPM Executable Path", "Optional: Full path to the npm executable (e.g., /Users/user/.asdf/shims/npm or C:\\path\\to\\npm.cmd). If not set, 'npm' from the system PATH will be used."), settings.NpmExecutablePath);
-            if (newNpmPath != settings.NpmExecutablePath)
-            {
-                settings.NpmExecutablePath = newNpmPath;
-                settings.SaveSettings();
-            }
-            
-            EditorGUILayout.Space();
-            
             // Server control buttons
             EditorGUILayout.BeginHorizontal();
             
@@ -210,6 +200,16 @@ private void DrawServerTab()
             }
                 
             EditorGUILayout.EndVertical();
+
+            // NPM Executable Path
+            string newNpmPath = EditorGUILayout.TextField(new GUIContent("NPM Executable Path", "Optional: Full path to the npm executable (e.g., /Users/user/.asdf/shims/npm or C:\\path\\to\\npm.cmd). If not set, 'npm' from the system PATH will be used."), settings.NpmExecutablePath);
+            if (newNpmPath != settings.NpmExecutablePath)
+            {
+                settings.NpmExecutablePath = newNpmPath;
+                settings.SaveSettings();
+            }
+            
+            EditorGUILayout.Space();
             
             // MCP Config generation section
             EditorGUILayout.Space();
diff --git a/Editor/UnityBridge/McpUnitySettings.cs b/Editor/UnityBridge/McpUnitySettings.cs
@@ -74,6 +74,11 @@ public void LoadSettings()
                     string json = File.ReadAllText(SettingsPath);
                     JsonUtility.FromJsonOverwrite(json, this);
                 }
+                else
+                {
+                    // Create default settings file on the first time initialization
+                    SaveSettings();
+                }
             }
             catch (Exception ex)
             {
diff --git a/Editor/Utils/McpUtils.cs b/Editor/Utils/McpUtils.cs
@@ -354,24 +354,18 @@ public static void RunNpmCommand(string arguments, string workingDirectory)
 
                     if (process.ExitCode == 0)
                     {
-                        Debug.Log($"[MCP Unity] npm {arguments} completed successfully in {workingDirectory}.");
+                        Debug.Log($"[MCP Unity] npm {arguments} completed successfully in {workingDirectory}.\n{output}");
                     }
                     else
                     {
-                        Debug.LogError($"[MCP Unity] npm {arguments} failed in {workingDirectory}. Exit Code: {process.ExitCode}");
+                        Debug.LogError($"[MCP Unity] npm {arguments} failed in {workingDirectory}. Exit Code: {process.ExitCode}. Error: {error}");
                     }
-                    
-                    if (!string.IsNullOrEmpty(output)) Debug.Log($"[MCP Unity] Output:\n{output}");
-                    if (!string.IsNullOrEmpty(error)) Debug.LogError($"[MCP Unity] Error:\n{error}");
                 }
             }
-            catch (System.ComponentModel.Win32Exception ex) // Catch specific exception for "file not found"
-            {
-                Debug.LogError($"[MCP Unity] Failed to run npm command '{shellCommand} {shellArguments}'. Ensure Node.js and npm are installed and in your system's PATH. Error: {ex.Message}");
-            }
             catch (Exception ex)
             {
-                Debug.LogError($"[MCP Unity] Exception while running npm command '{shellCommand} {shellArguments}' in {workingDirectory}: {ex.Message}\nDetails: {ex.StackTrace}");
+                // Use commandToLog here
+                Debug.LogError($"[MCP Unity] Exception while running npm {arguments} in {workingDirectory}. Error: {ex.Message}");
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,11 @@ public void LoadSettings()`
`74`	`74`	`string json = File.ReadAllText(SettingsPath);`
`75`	`75`	`JsonUtility.FromJsonOverwrite(json, this);`
`76`	`76`	`}`
	`77`	`+ else`
	`78`	`+ {`
	`79`	`+ // Create default settings file on the first time initialization`
	`80`	`+ SaveSettings();`
	`81`	`+ }`
`77`	`82`	`}`
`78`	`83`	`catch (Exception ex)`
`79`	`84`	`{`
Original file line number	Diff line number	Diff line change
`@@ -354,24 +354,18 @@ public static void RunNpmCommand(string arguments, string workingDirectory)`
`354`	`354`
`355`	`355`	`if (process.ExitCode == 0)`
`356`	`356`	`{`
`357`		`- Debug.Log($"[MCP Unity] npm {arguments} completed successfully in {workingDirectory}.");`
	`357`	`+ Debug.Log($"[MCP Unity] npm {arguments} completed successfully in {workingDirectory}.\n{output}");`
`358`	`358`	`}`
`359`	`359`	`else`
`360`	`360`	`{`
`361`		`- Debug.LogError($"[MCP Unity] npm {arguments} failed in {workingDirectory}. Exit Code: {process.ExitCode}");`
	`361`	`+ Debug.LogError($"[MCP Unity] npm {arguments} failed in {workingDirectory}. Exit Code: {process.ExitCode}. Error: {error}");`
`362`	`362`	`}`
`363`		`-`
`364`		`- if (!string.IsNullOrEmpty(output)) Debug.Log($"[MCP Unity] Output:\n{output}");`
`365`		`- if (!string.IsNullOrEmpty(error)) Debug.LogError($"[MCP Unity] Error:\n{error}");`
`366`	`363`	`}`
`367`	`364`	`}`
`368`		`- catch (System.ComponentModel.Win32Exception ex) // Catch specific exception for "file not found"`
`369`		`- {`
`370`		`- Debug.LogError($"[MCP Unity] Failed to run npm command '{shellCommand} {shellArguments}'. Ensure Node.js and npm are installed and in your system's PATH. Error: {ex.Message}");`
`371`		`- }`
`372`	`365`	`catch (Exception ex)`
`373`	`366`	`{`
`374`		`- Debug.LogError($"[MCP Unity] Exception while running npm command '{shellCommand} {shellArguments}' in {workingDirectory}: {ex.Message}\nDetails: {ex.StackTrace}");`
	`367`	`+ // Use commandToLog here`
	`368`	`+ Debug.LogError($"[MCP Unity] Exception while running npm {arguments} in {workingDirectory}. Error: {ex.Message}");`
`375`	`369`	`}`
`376`	`370`	`}`
`377`	`371`	`}`