perf: Optimize log type mapping performance in ConsoleLogsService

Saqoosha · claude · Saqoosha · commit 1ecfd45891eb · 2025-05-31T22:05:34.000+09:00
Move log type mapping logic outside the loop to avoid repeated processing. Added static Dictionary for MCP-to-Unity log type mappings with case-insensitive comparison. This improves performance and provides better extensibility for future log type mappings. Addresses CodeRabbit review feedback for performance optimization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/Editor/Services/ConsoleLogsService.cs b/Editor/Services/ConsoleLogsService.cs
@@ -12,6 +12,12 @@ namespace McpUnity.Services
     /// </summary>
     public class ConsoleLogsService : IConsoleLogsService
     {
+        // Static mapping for MCP log types to Unity log types
+        private static readonly Dictionary<string, string> LogTypeMapping = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase)
+        {
+            { "info", "Log" }
+        };
+        
         // Structure to store log information
         private class LogEntry
         {
@@ -76,15 +82,13 @@ public JArray GetAllLogsAsJson(string logType = "")
             JArray logsArray = new JArray();
             bool filter = !string.IsNullOrEmpty(logType);
             
+            // Map MCP log types to Unity log types outside the loop for better performance
+            string unityLogType = filter && LogTypeMapping.TryGetValue(logType, out string mapped) ? mapped : logType;
+            
             lock (_logEntries)
             {
                 foreach (var entry in _logEntries)
                 {
-                    // Map MCP log types to Unity log types
-                    string unityLogType = logType;
-                    if (logType.Equals("info", System.StringComparison.OrdinalIgnoreCase))
-                        unityLogType = "Log";
-                    
                     if (filter && !entry.Type.ToString().Equals(unityLogType, System.StringComparison.OrdinalIgnoreCase))
                         continue;
                     logsArray.Add(new JObject
