fix(ui-service): resolve Phase 1 critical bugs

Miguel Cartier · Miguel Cartier · commit 93531701411b · 2025-10-09T10:49:56.000+03:00
- Fix delay timing bugs in PresenterDelayerBase (wrong delay, missing unit conversion)
- Fix unit conversion in AnimationDelayer (remove incorrect * 1000 multiplication)
- Fix null reference in UiService.GetOrLoadUiAsync
- Fix DelayUiPresenterData&lt;T&gt; inheritance (wrong base class)

All critical blocking bugs from the architecture evaluation are now resolved.
diff --git a/Runtime/DelayUiPresenter.cs b/Runtime/DelayUiPresenter.cs
@@ -65,7 +65,7 @@ internal override void InternalClose(bool destroy)
 	/// </remarks>
 	/// <typeparam name="T">The type of data held by the presenter.</typeparam>
 	[RequireComponent(typeof(PresenterDelayerBase))]
-	public abstract class DelayUiPresenterData<T> : UiPresenter, IUiPresenterData where T : struct
+	public abstract class DelayUiPresenterData<T> : UiPresenter<T> where T : struct
 	{
 		[SerializeField] private PresenterDelayerBase _delayer;
 
diff --git a/Runtime/Delayers/AnimationDelayer.cs b/Runtime/Delayers/AnimationDelayer.cs
@@ -11,15 +11,15 @@ namespace GameLovers.UiService
 	[RequireComponent(typeof(Animation))]
 	public class AnimationDelayer : PresenterDelayerBase
 	{
-		[SerializeField] protected Animation _animation;
-		[SerializeField] protected AnimationClip _introAnimationClip;
-		[SerializeField] protected AnimationClip _outroAnimationClip;
+	[SerializeField] protected Animation _animation;
+	[SerializeField] protected AnimationClip _introAnimationClip;
+	[SerializeField] protected AnimationClip _outroAnimationClip;
 
-		/// <inheritdoc />
-		public override float OpenDelayInSeconds => _introAnimationClip.length * 1000;
+	/// <inheritdoc />
+	public override float OpenDelayInSeconds => _introAnimationClip.length;
 
-		/// <inheritdoc />
-		public override float CloseDelayInSeconds => _outroAnimationClip.length * 1000;
+	/// <inheritdoc />
+	public override float CloseDelayInSeconds => _outroAnimationClip.length;
 
 		private void OnValidate()
 		{ 
diff --git a/Runtime/Delayers/PresenterDelayerBase.cs b/Runtime/Delayers/PresenterDelayerBase.cs
@@ -45,33 +45,33 @@ protected virtual void OnOpenStarted() { }
 		/// </summary>
 		protected virtual void OnCloseStarted() { }
 
-		internal async Task OpenWithDelay(Action onOpenedCompleted)
-		{
-			OnOpenStarted();
+	internal async Task OpenWithDelay(Action onOpenedCompleted)
+	{
+		OnOpenStarted();
 
-			CurrentDelayTask = Task.Delay(Mathf.RoundToInt(OpenDelayInSeconds));
+		CurrentDelayTask = Task.Delay(Mathf.RoundToInt(OpenDelayInSeconds * 1000));
 
-			await CurrentDelayTask;
+		await CurrentDelayTask;
 
-			if (gameObject != null)
-			{
-				onOpenedCompleted();
-			}
+		if (gameObject != null)
+		{
+			onOpenedCompleted();
 		}
+	}
 
-		internal async Task CloseWithDelay(Action onCloseCompleted)
-		{
-			OnCloseStarted();
+	internal async Task CloseWithDelay(Action onCloseCompleted)
+	{
+		OnCloseStarted();
 
-			CurrentDelayTask = Task.Delay(Mathf.RoundToInt(OpenDelayInSeconds));
+		CurrentDelayTask = Task.Delay(Mathf.RoundToInt(CloseDelayInSeconds * 1000));
 
-			await CurrentDelayTask;
+		await CurrentDelayTask;
 
-			if (gameObject != null)
-			{
-				gameObject.SetActive(false);
-				onCloseCompleted();
-			}
+		if (gameObject != null)
+		{
+			gameObject.SetActive(false);
+			onCloseCompleted();
 		}
 	}
+	}
 }
diff --git a/Runtime/UiService.cs b/Runtime/UiService.cs
@@ -354,18 +354,18 @@ private void OpenUi(Type type)
 			_visibleUiList.Add(type);
 		}
 
-		private async UniTask<UiPresenter> GetOrLoadUiAsync(Type type)
+	private async UniTask<UiPresenter> GetOrLoadUiAsync(Type type)
+	{
+		if (!_uiPresenters.TryGetValue(type, out var ui))
 		{
-			if (!_uiPresenters.TryGetValue(type, out var ui))
-			{
-				OpenLoadingSpinner();
-				await LoadUiAsync(type);
-				CloseLoadingSpinner();
-			}
-
-			return ui;
+			OpenLoadingSpinner();
+			ui = await LoadUiAsync(type);
+			CloseLoadingSpinner();
 		}
 
+		return ui;
+	}
+
 		private void OpenLoadingSpinner()
 		{
 			if (_loadingSpinnerType == null)

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ internal override void InternalClose(bool destroy)`
`65`	`65`	`/// </remarks>`
`66`	`66`	`/// <typeparam name="T">The type of data held by the presenter.</typeparam>`
`67`	`67`	`[RequireComponent(typeof(PresenterDelayerBase))]`
`68`		`- public abstract class DelayUiPresenterData<T> : UiPresenter, IUiPresenterData where T : struct`
	`68`	`+ public abstract class DelayUiPresenterData<T> : UiPresenter<T> where T : struct`
`69`	`69`	`{`
`70`	`70`	`[SerializeField] private PresenterDelayerBase _delayer;`
`71`	`71`