perf(ui-service): optimize collection types for better performance

Miguel Cartier · Miguel Cartier · commit 744d33f6e6ae · 2025-11-03T01:06:15.000+02:00
fix(editor): ensure serialization updates before property binding
refactor(editor): rename UI set enum values for clarity
diff --git a/Editor/DefaultUiConfigsEditor.cs b/Editor/DefaultUiConfigsEditor.cs
@@ -9,12 +9,12 @@ namespace GameLoversEditor.UiService
 	/// </summary>
 	public enum DefaultUiSetId
 	{
-		None = 0,
+		InitialLoading = 0,
 		MainMenu = 1,
 		Gameplay = 2,
 		Settings = 3,
-		Overlay = 4,
-		Popup = 5
+		Overlays = 4,
+		Popups = 5
 	}
 
 	/// <summary>
diff --git a/Editor/UiConfigsEditor.cs b/Editor/UiConfigsEditor.cs
@@ -81,11 +81,14 @@ private void OnEnable()
 
 			SyncConfigsWithAddressables();
 			
-			_configsProperty = serializedObject.FindProperty("_configs");
-			_setsProperty = serializedObject.FindProperty("_sets");
-			
 			// Ensure sets array matches enum size
 			_scriptableObject.SetSetsSize(Enum.GetNames(typeof(TSet)).Length);
+			
+			// Update the serializedObject to reflect the changes
+			serializedObject.Update();
+			
+			_configsProperty = serializedObject.FindProperty("_configs");
+			_setsProperty = serializedObject.FindProperty("_sets");
 		}
 
 		/// <inheritdoc />
diff --git a/Runtime/UiConfigs.cs b/Runtime/UiConfigs.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using UnityEngine;
 
 // ReSharper disable CheckNamespace
@@ -51,6 +52,8 @@ public List<UiConfig> Configs
 		/// <param name="size">The new size of the list</param>
 		public void SetSetsSize(int size)
 		{
+			var validAddresses = new HashSet<string>(_configs.Select(c => c.AddressableAddress));
+			
 			if (size < _sets.Count)
 			{
 				_sets.RemoveRange(size, _sets.Count - size);
@@ -60,18 +63,8 @@ public void SetSetsSize(int size)
 			{
 				if (i < _sets.Count)
 				{
-					var cleanedConfigList = new List<string>(_sets[i].UiConfigsAddress.Count);
-
-					foreach (var address in _sets[i].UiConfigsAddress)
-					{
-						if (_configs.FindIndex(config => config.AddressableAddress == address) > -1)
-						{
-							cleanedConfigList.Add(address);
-						}
-					}
-
 					var set = _sets[i];
-					set.UiConfigsAddress = cleanedConfigList;
+					set.UiConfigsAddress.RemoveAll(address => !validAddresses.Contains(address));
 					_sets[i] = set;
 					continue;
 				}
diff --git a/Runtime/UiSetConfig.cs b/Runtime/UiSetConfig.cs
@@ -13,7 +13,7 @@ namespace GameLovers.UiService
 	public struct UiSetConfig
 	{
 		public int SetId;
-		public IReadOnlyList<Type> UiConfigsType;
+		public Type[] UiConfigsType;
 	}
 
 	/// <summary>
@@ -27,19 +27,28 @@ public struct UiSetConfigSerializable
 
 		public static UiSetConfig ToUiSetConfig(UiSetConfigSerializable serializable, List<UiConfigs.UiConfigSerializable> configs)
 		{
-			var types = new List<Type>();
+			var types = new Type[serializable.UiConfigsAddress.Count];
+			var index = 0;
+			
 			foreach (var address in serializable.UiConfigsAddress)
 			{
 				var config = configs.Find(c => c.AddressableAddress == address);
 				if (!string.IsNullOrEmpty(config.UiType))
 				{
-					types.Add(Type.GetType(config.UiType));
+					types[index++] = Type.GetType(config.UiType);
 				}
 			}
+			
+			// Trim array if some addresses weren't found
+			if (index < types.Length)
+			{
+				Array.Resize(ref types, index);
+			}
+			
 			return new UiSetConfig 
 			{ 
 				SetId = serializable.SetId, 
-				UiConfigsType = types.AsReadOnly() 
+				UiConfigsType = types 
 			};
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ namespace GameLovers.UiService`
`13`	`13`	`public struct UiSetConfig`
`14`	`14`	`{`
`15`	`15`	`public int SetId;`
`16`		`- public IReadOnlyList<Type> UiConfigsType;`
	`16`	`+ public Type[] UiConfigsType;`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`/// <summary>`
`@@ -27,19 +27,28 @@ public struct UiSetConfigSerializable`
`27`	`27`
`28`	`28`	`public static UiSetConfig ToUiSetConfig(UiSetConfigSerializable serializable, List<UiConfigs.UiConfigSerializable> configs)`
`29`	`29`	`{`
`30`		`- var types = new List<Type>();`
	`30`	`+ var types = new Type[serializable.UiConfigsAddress.Count];`
	`31`	`+ var index = 0;`
	`32`	`+`
`31`	`33`	`foreach (var address in serializable.UiConfigsAddress)`
`32`	`34`	`{`
`33`	`35`	`var config = configs.Find(c => c.AddressableAddress == address);`
`34`	`36`	`if (!string.IsNullOrEmpty(config.UiType))`
`35`	`37`	`{`
`36`		`- types.Add(Type.GetType(config.UiType));`
	`38`	`+ types[index++] = Type.GetType(config.UiType);`
`37`	`39`	`}`
`38`	`40`	`}`
	`41`	`+`
	`42`	`+ // Trim array if some addresses weren't found`
	`43`	`+ if (index < types.Length)`
	`44`	`+ {`
	`45`	`+ Array.Resize(ref types, index);`
	`46`	`+ }`
	`47`	`+`
`39`	`48`	`return new UiSetConfig`
`40`	`49`	`{`
`41`	`50`	`SetId = serializable.SetId,`
`42`		`- UiConfigsType = types.AsReadOnly()`
	`51`	`+ UiConfigsType = types`
`43`	`52`	`};`
`44`	`53`	`}`
`45`	`54`