Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally pass through the CultureInfo instance in the XLWorkbook instance #1367

Open
Pankraty opened this issue Mar 12, 2020 · 2 comments
Open

Optionally pass through the CultureInfo instance in the XLWorkbook instance #1367

Pankraty opened this issue Mar 12, 2020 · 2 comments

Comments

@Pankraty
Copy link
Member

Follow-up to #1359

This relates to a comment I made somewhere in another PR. I think we should optionally pass through the CultureInfo instance in the XLWorkbook instance and use that everywhere where applicable. Default to CurrentCulture. We'll have to do a separate PR for that.

Originally posted by @igitur in https://github.com/ClosedXML/ClosedXML/pull/1359/files
@Pankraty Pankraty mentioned this issue Mar 30, 2020
Closed
2 tasks
This was referenced Apr 16, 2020
Closed
Merged
@Pankraty Pankraty reopened this Apr 18, 2020
@Pankraty
Copy link
Member Author

Was closed by mistake, apparently

@igitur
Copy link
Member

igitur commented Apr 18, 2020

Yes, sorry, typo on my side.

@jahav jahav mentioned this issue Sep 19, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igitur @Pankraty