Deprecate `chia plotters install` command #13584

ChiaMineJP · 2022-10-02T15:54:12Z

Change log

Deprecated `chia plotters install` command

Removed relevant code. When you run chia plotters install command, deprecation warning will be shown like this:
[DEPRECATED] 'chia plotters install' is no longer available. Use install-plotter.sh/ps1 instead.

Please note that chia plotters version and chia plotters bladebit/madmax commands still searches for plotter binaries under $CHIA_ROOT/plotters to maintain compatibility with older version of the app.
Search priority:

venv/bin (venv/Scripts for Windows)
* Only for source installation with venv activated
$CHIA_ROOT/plotters
<package root>/resources/app.asar.unpacked/daemon/{bladebit, madmax}
* Only for package installation

Added `install-plotter.sh` / `Install-plotter.ps1`

Installing bladebit/madmax's pre-compiled binary into venv/bin (venv/Scripts for Windows)

Example usage
./install-plotter.sh bladebit
./install-plotter.sh bladebit -v v2.0.0-beta1
./install-plotter.sh madmax
./install-plotter.sh madmax -v 0.0.1

Note that if -v option is omitted:

install-plotter.sh bladebit will try to install bladebit v2.0.0. (which has not released yet at Oct 04, 2022)
install-plotter.sh madmax will try to install madmax 0.0.2.

Added `-p` option to `install.sh` / `Install.ps1`

-p: Additional plotter install option.

Example usage
./install.sh -p
This calls install-plotter.sh|ps1 internally and will try to install both bladebit and madmax. (For bladebit, it will try to install v2.0.0 which has not released yet for now, so it will fail with 'File Not Found' error)

lgtm-com · 2022-10-02T16:15:03Z

This pull request introduces 2 alerts and fixes 2 when merging f44c85214ecedd5c79a11c29c85637e9020d34ce into a5ea7fb - view on LGTM.com

new alerts:

2 for Unused import

fixed alerts:

2 for Module-level cyclic import

lgtm-com · 2022-10-02T17:08:02Z

This pull request fixes 9 alerts when merging 0ef58b863b8ad8cdaa31d59f04525a50e281a198 into a5ea7fb - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

lgtm-com · 2022-10-03T16:46:24Z

This pull request fixes 9 alerts when merging ed7d1942619aa405341c66a10a10372fb0aaeb86 into a5ea7fb - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

lgtm-com · 2022-10-03T17:14:37Z

This pull request fixes 9 alerts when merging b8af9bfe17eeb8594159810e6415ba2f34b3b1a6 into a5ea7fb - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

lgtm-com · 2022-10-03T17:45:16Z

This pull request fixes 9 alerts when merging 5a2a1b2eb7816019a9a21d4dc50f6ea5e587c79d into a5ea7fb - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

lgtm-com · 2022-10-03T18:18:19Z

This pull request fixes 9 alerts when merging 868daf26e74ff99c208bfec5a96861db2d77caf3 into a5ea7fb - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

lgtm-com · 2022-10-04T10:54:47Z

This pull request fixes 9 alerts when merging 304bd81946d75d3a9e08822f1e72b49222a668ec into c41d5a9 - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

lgtm-com · 2022-10-04T11:58:53Z

This pull request fixes 9 alerts when merging d7148bed33a598d8f6e4239861269bc61c540af3 into c41d5a9 - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

lgtm-com · 2022-10-04T13:09:39Z

This pull request fixes 9 alerts when merging 81ae5cf0202618cbc8c02ca63bd79943d96cb25e into c41d5a9 - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

wallentx

We should also implement a dependency check, or at least warn the use that they will need to install certain dependencies for the plotter to work.

install-plotter.sh

github-actions · 2022-10-04T16:25:40Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

… by 'chia plotters' command

…civated

github-actions · 2022-10-04T23:37:57Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

lgtm-com · 2022-10-04T23:54:18Z

This pull request fixes 9 alerts when merging a9f129f into 440b70a - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

The base branch was changed.

lgtm-com · 2022-10-17T17:17:08Z

This pull request fixes 9 alerts when merging a9f129f into b4ac518 - view on LGTM.com

fixed alerts:

9 for Module-level cyclic import

* Deprecated `chia plotters install` command * Fixed lint errors * Made it able to recognize plotter executables in venv * Added install-plotter.sh * Removed strings for debug * Added install-plotter.ps1 * Fixed an issue where madmax plotter under venv dir was not recognized by 'chia plotters' command * Added exec permission to install-plotter.sh * Fixed issues found in install-plotter.sh * Fixed lint errors * Added `-p` option to install.sh/install.ps1 * Fixed lint errors * Added nice deprecated warning * Fixed a lint error * Slightly improved branching * Made log messages look nice * Fixed an issue where install.sh/ps1 -p failed if virtual env is not acivated Co-authored-by: Izumi Hoshino <[email protected]>

* Deprecate `chia plotters install` command (#13584) (#13643) * Deprecated `chia plotters install` command * Fixed lint errors * Made it able to recognize plotter executables in venv * Added install-plotter.sh * Removed strings for debug * Added install-plotter.ps1 * Fixed an issue where madmax plotter under venv dir was not recognized by 'chia plotters' command * Added exec permission to install-plotter.sh * Fixed issues found in install-plotter.sh * Fixed lint errors * Added `-p` option to install.sh/install.ps1 * Fixed lint errors * Added nice deprecated warning * Fixed a lint error * Slightly improved branching * Made log messages look nice * Fixed an issue where install.sh/ps1 -p failed if virtual env is not acivated Co-authored-by: Izumi Hoshino <[email protected]> * Bump blspy from 1.0.15 to 1.0.16 (#13552) Bumps [blspy](https://github.com/Chia-Network/bls-signatures) from 1.0.15 to 1.0.16. - [Release notes](https://github.com/Chia-Network/bls-signatures/releases) - [Commits](Chia-Network/bls-signatures@1.0.15...1.0.16) --- updated-dependencies: - dependency-name: blspy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump dnslib from 0.9.17 to 0.9.22 (#13599) Bumps [dnslib](https://github.com/paulc/dnslib) from 0.9.17 to 0.9.22. - [Release notes](https://github.com/paulc/dnslib/releases) - [Commits](https://github.com/paulc/dnslib/commits/0.9.22) --- updated-dependencies: - dependency-name: dnslib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump clvm-tools-rs from 0.1.19 to 0.1.24 (#13626) Bumps [clvm-tools-rs](https://github.com/Chia-Network/clvm_tools_rs) from 0.1.19 to 0.1.24. - [Release notes](https://github.com/Chia-Network/clvm_tools_rs/releases) - [Commits](Chia-Network/clvm_tools_rs@0.1.19...0.1.24) --- updated-dependencies: - dependency-name: clvm-tools-rs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump chia-blockchain-gui to fe08ae6760b8ab4878e98cdff8f13e3b9e6578cf Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Amine Khaldi <[email protected]> Co-authored-by: Izumi Hoshino <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: William Allen <[email protected]>

ChiaMineJP requested a review from a team as a code owner October 2, 2022 15:54

ChiaMineJP marked this pull request as draft October 2, 2022 15:54

ChiaMineJP self-assigned this Oct 2, 2022

ChiaMineJP marked this pull request as ready for review October 3, 2022 18:01

ChiaMineJP requested review from esaung, paninaro and wallentx October 3, 2022 18:02

wallentx suggested changes Oct 4, 2022

View reviewed changes

install-plotter.sh Show resolved Hide resolved

github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 4, 2022

ChiaMineJP added 11 commits October 5, 2022 08:32

Deprecated chia plotters install command

a7b7611

Fixed lint errors

3973037

Made it able to recognize plotter executables in venv

ff511fa

Added install-plotter.sh

328abcc

Removed strings for debug

a98ce22

Added install-plotter.ps1

ec51129

Fixed an issue where madmax plotter under venv dir was not recognized…

52b817b

… by 'chia plotters' command

Added exec permission to install-plotter.sh

18c9127

Fixed issues found in install-plotter.sh

11d72aa

Fixed lint errors

6f6e453

Added -p option to install.sh/install.ps1

fe0be98

ChiaMineJP added 6 commits October 5, 2022 08:36

Fixed lint errors

3e9cd73

Added nice deprecated warning

da1d52c

Fixed a lint error

d3d68fe

Slightly improved branching

f8c7d61

Made log messages look nice

c98eb6b

Fixed an issue where install.sh/ps1 -p failed if virtual env is not a…

a9f129f

…civated

ChiaMineJP force-pushed the cmj.bladebit-install branch from 81ae5cf to a9f129f Compare October 4, 2022 23:37

github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 4, 2022

wallentx previously approved these changes Oct 17, 2022

View reviewed changes

wallentx changed the base branch from main to release/1.6.1 October 17, 2022 17:00

paninaro approved these changes Oct 17, 2022

View reviewed changes

wallentx merged commit 0e93464 into release/1.6.1 Oct 17, 2022

wallentx deleted the cmj.bladebit-install branch October 17, 2022 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate `chia plotters install` command #13584

Deprecate `chia plotters install` command #13584

ChiaMineJP commented Oct 2, 2022 •

edited

Loading

lgtm-com bot commented Oct 2, 2022

lgtm-com bot commented Oct 2, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 4, 2022

lgtm-com bot commented Oct 4, 2022

lgtm-com bot commented Oct 4, 2022

wallentx left a comment

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

lgtm-com bot commented Oct 4, 2022

lgtm-com bot commented Oct 17, 2022

Deprecate chia plotters install command #13584

Deprecate chia plotters install command #13584

Conversation

ChiaMineJP commented Oct 2, 2022 • edited Loading

Change log

Deprecated chia plotters install command

Added install-plotter.sh / Install-plotter.ps1

Added -p option to install.sh / Install.ps1

lgtm-com bot commented Oct 2, 2022

lgtm-com bot commented Oct 2, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 3, 2022

lgtm-com bot commented Oct 4, 2022

lgtm-com bot commented Oct 4, 2022

lgtm-com bot commented Oct 4, 2022

wallentx left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2022

github-actions bot commented Oct 4, 2022

lgtm-com bot commented Oct 4, 2022

lgtm-com bot commented Oct 17, 2022

Deprecate `chia plotters install` command #13584

Deprecate `chia plotters install` command #13584

ChiaMineJP commented Oct 2, 2022 •

edited

Loading

Deprecated `chia plotters install` command

Added `install-plotter.sh` / `Install-plotter.ps1`

Added `-p` option to `install.sh` / `Install.ps1`