Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GIL release #250

Merged
merged 1 commit into from
Jul 17, 2021
Merged

remove GIL release #250

merged 1 commit into from
Jul 17, 2021

Conversation

wjblanke
Copy link
Contributor

No description provided.

arvidn
arvidn approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it this is an exhaustive list of all Py_BEGIN_ALLOW_THREADS, right?

@wjblanke
Copy link
Contributor Author

Py_BEGIN_ALLOW_THREADS

I think so

Williams-MacBook-Pro:bls-signatures bill$ grep -r Py_BEGIN_ALLOW_THREADS *
python-bindings/pythonbindings.cpp: // Py_BEGIN_ALLOW_THREADS

@wjblanke wjblanke merged commit 3c3cfb4 into main Jul 17, 2021
@wjblanke wjblanke deleted the killgil branch July 17, 2021 16:18
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Dec 1, 2021
@wjblanke @UdjinM6
remove GIL release (Chia-Network#250)
c5e2ad4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@xdustinface xdustinface Awaiting requested review from xdustinface

@rostislav rostislav Awaiting requested review from rostislav

@mariano54 mariano54 Awaiting requested review from mariano54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjblanke @arvidn