-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add javascript binding tests #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjblanke
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
UdjinM6
pushed a commit
to UdjinM6/bls-signatures
that referenced
this pull request
Dec 1, 2021
* Add javascript binding tests * install emsdk * separate install emsdk and test
Fuzzbawls
added a commit
to Fuzzbawls/bls-signatures
that referenced
this pull request
Jan 21, 2022
bf371297 Merge pull request Chia-Network#219 from Fuzzbawls/2022_remove-redundant-decls ddaeb28a Remove redundant declarations in relic_fpx.h 97081d11 Minor speedup in LaPSI with cool trick on the exponent. 4107d14c Update LABEL support. 499a65a1 Better test and fixed memm alloc issue for PSI. bbe8963e Memory allocation issue. a3533dde Addind pairing-based PSI protocol. e1b388a0 Trim bn_t at the end of copy. 8930b261 Restore benchmarks. e9c681ab Fix bugs in EXTND coordinate system. 49b2a0d1 Respect STRIP. a953d385 Fix symbol name. 5260f210 Build with stripping enabled. 4848f27d Fix problems with compression and blinding on EDDIE. e4dd23d3 Remove redundant assignment. 50935c18 One more fix for EDDIE. 01433d7f Do not zero buffers without need. 2601df77 Make EDDIE compile with STRIP again. 6d29b274 Share more code between jumpdivstep inversion/symbol. 0f4a481f Refactoring of jumpdivstep inversion/symbol to share code. f333841c Add missing present. cb488ee4 Fix preset. 842cb1f8 Giving up again, problem is with GNU as and our macros. 970fac17 Trying again... 5d26c6a8 Fix typo. eb09222d Another attempt at MacOS integration. 83090950 Merge pull request Chia-Network#216 from feandalo/patch-1 64a5e5e0 Update README.md c56f2cc3 Remove MacOS for a while due to GCC shenanigans. 4a5b2527 Trying another compiler for MacOS. 052c1bf6 Fix artifact of the previous merge. f8431f32 Fix syntax. 7d269435 Reorder CMake commands to see if config works. bb278393 Merge pull request Chia-Network#215 from relic-toolkit/symbol 30f5b659 Fix signal on symbol computation as well. 9a001ec7 Fix for small limb sizes. 896022b3 Formatting. 2f081928 Fixed another bug in bn_mul2_low(). 0c50b590 Another bug fixed. a54c32c5 Fix carry issue in shifting functions. 06cff1fa Update LABEL support with new symbol functions. 37af1f4a Clarify this little hack. 0fce7d3f Merge branch 'main' into symbol 5ffc7f8c Fix bugs with divstep config and return value. 536422ad Update interface of the BN symbol functions. c274e2b2 Update presets to complete configuration. 6c046a07 Better formatting. e7a15a36 Remove compilation warning. 11592073 Add more missing files for Legendre. 6a2d8b9b Benchmark missing algorithm. f5f36c07 Add another missing file, fix dates. b7bbfa11 Fix default low-level implementation of Legendre. a545d806 Add missing file. f21d15ca Refactor configuration to include Legendre symbol, improve tests/bench. d4747b69 Remove warning. 0b49c334 Fixed bug when prime is close to power of 2. b06d27e5 Fix documentation of EP methods. 63aa2e29 Bump version for new future release. a269b6db Fix allocation issue. 4ae9c899 Adjust batch size. 66993770 Simplify API and optimize constant-time execution. e3f82e36 Rename workflow run. 0be5e47d Remove warning. df5ce77a Restore commented out function. f1688dd4 Replace dbl_t type with macros. ab40d2f6 Fix typo. 24602b1b Add missing tests, label and benchmarks. bb5a5dba Refactor divstep-based inversion. 1c6ef422 Fix type. 975573ee New jacobi symbol algorithm. acdcf436 Merge pull request Chia-Network#213 from lorenzcat/main 3ab3a08f Fix NETBSD definition 260c9f8b More bug fixes involving inputs/outputs and corner cases for scalars. ecaf98f9 Fix regression. 72e5652a Improve coverage of corner cases in tests. a001e3e0 Simplify handling of scalars out of bounds. 7bc1d747 Make outputs independent of inputs. 156156a5 Fix sign bug in ep2_mul_sim_lot(). 729bbc18 Fix LABEL and add GH Action for detecting regressions. a33d45bd Add SMLERS. dc851e38 Better printing. cb2075dd Simplify code. 06f30d89 Update demo. edd1aa0c Fix more. 89609c9e Fix compile error. cf3a82a7 Add SMLERS and generalize SoK protocol. 64523296 Add bn_mod_inv_sim(), tests and benchmarks. 42790a02 Fix for ED module. 7a80c3e2 Improve documentation and flexibility of ep_mul_sim_lot(). edf5bd94 Merge branch 'main' of github.com:relic-toolkit/relic 804e5b7f Fix compile error with LABEL. aecdcae7 Merge pull request Chia-Network#209 from luozejiaqun/patch-1 220d9c9e Add embedding degree for SM9 curve. f09f1346 Fix copy for other memory allocators. a143e5a0 Remove printing artifact. efcc66db Optimize *_mul_sim_lot() similarly. 16af34c1 Restore the original BN-256 as the default parameter choice. 17b29504 Add SM9 curve (BN) over 256-bit prime and rename CP8 -> GMT8. 1f62f589 Add benchmarks for ep_mul_sim_lot(). 3429421e Fix subgroup membership test in G1. 3dd26f5a Identation and other minor things. f8466af7 Merge pull request Chia-Network#205 from huitseeker/open_ep_maps fd00df0f Merge branch 'main' of https://github.com/relic-toolkit/relic 47173111 Change size of challenge to match paper. 662ebfb7 Update README.md 1ceb569a Check that points read from buffers are on the curve. b7b2266a Remove warning of type mismatch. 7ed8e702 Fix comparison bug caused by casting reported by cryptofuzz. 4ef8f9c4 Include headersin editor config. c259f6ec Fix identation in GitHub. 5b795881 Make exception-handling code more robust. f476b78c Remove unused protocol. f8a7908e Faster exponentiation for small integers. acafbd6c Replace signed char with int8_t. c46e6657 Faster multiplication by short scalars, unify terminology. 202f7476 Test smaller challeges in pairing delegation protocols. 46742aef Add new algorithm. e9948b70 Initialize buffers with 0. 36cb0960 Remove compilation warnings. 1620a03b Handle invalid encodings at a better place. e580a217 Try optimization agan. 5efbe691 Fix macro. 51e78785 Specialize reduction to recover minor speedup. a0b5cf54 Polish membership testing in G_T for prime-order curves. c7177c87 Fix very old bug introduced to handle a special case and never updated. dfa21290 Fix parameter. e6209fd8 Increase robustness of non-initialized bignums. d834ca4b Better place for exception throwing. 6d28711c Zero digits in recoding functions to simplify upper layer. 293beaf8 Add missing header. ced4f230 Fixes. 8eec5159 Implementing blinding on twists for projective coordinates. ff180c1e Avoid allocation rollbacks when errors occur. a78ceb24 Fix comment, add missing error message. 9a012863 Add a direct map from field to curve 9bca8fc4 Remove duplicate header for ep_map_dst 09b8ff20 Add self-test for PRNG when callback is used. 2f0273c5 Minor fixes. f49ae035 More conservative optimization. 7fb584fa Add new symbol computations, more work to be done on the API. 82f87cef Removed unused include. 49e5486a Another fix for EPX == ep4 case. 4e2040a1 Fix GMP crash. 1b4d4ae8 Several minor fixes in FP and EPX. Implements ep4_mul_sim_lot(). cfa81d08 Pick correct curve when exponentiating G_T elements. 2a74905d Minor fix. 2e346579 Typos. 15cb6d1d Refactor to reduce code duplication. 30b67cbd Another fix. ff2cf630 Fix typo. 73799126 Reduze size of regular recoding by one. 2f95c443 Better tests for the group order. 7991e63d Restore commented out tests. 9206ae50 Attempt to fix alignment issue. 17685344 Minor touches to protocols. ECIES nos supports legacy curves. e2b7ffc2 More refined benchmarks. bcda30a3 Refinement. 92c72508 Add ETRS to bench program. 696ddd77 Fix memory errors. f58ce726 Refine benchmarking of ETRS further. f5486775 Another try. 00c66b68 Reduce benchmarks size. bf601552 Add ETRS scheme. af858769 Add ETRS scheme. 5234fc6e Better benchmarking for ERS. 1ee21e7c Add better config for ed25519 curve. 1b7d6487 Add demo for ERS/ETRS scheme. ecc5f7e8 Add demo for ERS/ETRS scheme. ebea1e0e Update the backend for generality. 442ee0a7 Adjustments to ERS. 54676b0b Better bench. 946110d5 Improve benchmark for ERS. 9b97cf0f More experiments with GT membership checks. e79a5781 Further fixes in FPX exponentiation. f1452124 Polishing. 37f5cecc Implement 8-GLS method for BLS24. ab14b575 Better GLV/GLS for curves and fields. 5887c2e2 Add hashing to BLS24 curves. c4116a4d Memory bugs! 0e491e8b Square root in Fp4. e99711b3 Faster cyclotomic squarings. db2d6a9e Faster efficient membership tests again, getting there! fe3ea6f9 Merge branch 'main' of github.com:relic-toolkit/relic f1d9e3bf Better GT test for BLS24. d524ff0f Update relic_ep_param.c 6cd1e3fc Add BLS12-383 curve and adjust backends. 73e4bde8 Make more general. 4b465952 Make subgroup membership tests less risky again. 26467be7 Combined low-level backends. d2723fda Remove apparently useless CMake directive. a970b292 Another type fix. a20f81f0 Fix conditional compilation. 18eeb970 Merge branch 'main' of github.com:relic-toolkit/relic 29cd6315 Added new preset for BLS24 curve. 45a1bf0f Rename folder and preset. f6634219 Make code a little more generic. 1cae37af Fix types. a30eebc2 Fix error caused by previous merge. 49790b6c Fix type. 97ff7774 Merge pull request Chia-Network#199 from relic-toolkit/delegation 320774a2 Merge branch 'main' into delegation c52bb96c Rename protocols. 8775b479 Add more benchmarks. 9149cead Fix membership tests. 4834f435 Use random points. 730bc944 More general choice of algs. 10168f0f Fix another memory issue. 0a265de4 Implement pairings over BLS24 and add glue code for protocols. 19dcfac7 Fix memory issues. 67abb197 Fix type mismatch. 634c0529 Stub for compression and adjustment for fp4_mul_frb(). 48778406 Adjust benchmarks as well. eda52e70 Complete implementation of Fp24. 3738c50d Add implementation of E(Fp4). 456e61a5 Extended Fp4 with new functions. 4c9be555 Rename variables to follow standard. 638291c6 Minor polishing. 52b316a6 Fix memory issue. 771e9f71 Replace curve BLS24-477 with BLS24-509. 3a9160b1 Fix copyright dates, add script. 0a19bdbb Removing include and list type. d3645687 Add extendable ring signatures. 877f8e75 Fix memory issues. 999cd0c5 Add SoK protocols for discrete logarithms. a689b8ff Add PoK protocols for dlogs. aff5b254 Add new GHA configuration. 5f4bf29e Fix issues with constant-time GMP backend. 4e39e235 Remove unused variable. 6314936f Otimize GHA by reducing number of tests. 36c03729 Accelerate GHA by omitting excessive configurations. 4776b432 Change types and fix constant overflow. 173b674a Bug fixes detected by GHA. de470937 Slightly more readable code. 65960446 Do not resize WSIZE after it was set once. 60008aa1 Remove printing artifact. af425eca Fix test cases for trivial values of b. 9fa0f13a Rename config. 511bacef Add configurations for 8- and 16-bit microcontrollers to GHA. 784711bc Merge branch 'main' of github.com:relic-toolkit/relic 8d45773e Rename GHA config. 1a98c503 Refresh GHA configurations. 5daada8c Update README.md 5a5e2819 Merge pull request Chia-Network#197 from relic-toolkit/win64 bc11fc82 Fix documentation. fda22d02 Reuse macros and simplify EASY backend. 69c51954 Fix more issues with BLAKE2. 03f86cb5 Rename bn_init -> bn_make to avoid clashing with OpenSSL. 43f2cd46 Fix issue with BLAKE2. c457c28b Added Curve448 prime. 74a45c10 Compute the generator of G_T here. 63088b36 Merge pull request Chia-Network#194 from luozejiaqun/pcGtGen 1b9a2f93 Fix typo. 236330b2 Simplify generator getting for Gt. 23627901 Rename for clarity. 23175371 Merge branch 'win64' of github.com:relic-toolkit/relic into win64 ec0323d6 Attempt to fix Win64 crash. 1964462b More fixes for Win64, almost there. c5619102 New fix for Win64. eee28940 Fix compile issues on Win64. 70d29ddb Typo. 5cf20c4c Another attempt to make code more portable. 5d299329 Make code more portable. 1df86afd Attempt to abstract multiplication/division involving single digits. ebf7c8da Remove another occurence of dbl_t for Win64. 11d4414e Another fix. efded21a Fix compile error on Win64. 1862a1f2 Attempt to compile on WIN64. bf2b8035 Formatting. 252a53d4 Simplify iterated squaring interface to save memory on context. 6e4aaa56 Attempt to fix Win64 crash. 85fc0d45 More fixes for Win64, almost there. f2ac7567 New fix for Win64. 7e3433e6 Fix compile issues on Win64. f205ef68 Typo. 45bdce9f Another attempt to make code more portable. bb9f7b6d Make code more portable. 70cef2fb Attempt to abstract multiplication/division involving single digits. 879ae213 Remove another occurence of dbl_t for Win64. 328865bf Another fix. ca718dea Fix compile error on Win64. 52af7c93 Merge branch 'win64' of github.com:relic-toolkit/relic into win64 1f6ec607 Attempt to compile on WIN64. ec291eca Attempt to compile on WIN64. 9bee0e2f Improve detection for Windows 64. d9ea26cf Improve detection for Windows 64. b3e4bb6a Improve detection for Windows 64. e6702621 Conditional ASM directives. a6b49fe0 Change RNG for Windows build. c2617189 Remove apparently seless directives from ASM in BLS12-381. 5f94a5ba One more try. 1e8748ca Restore GMP config. d45fe501 More fixes. a9051913 Another fix. cee373b4 Fix typo in preset name. f49a187f Add new configuration for GH Actions. c7efde00 Minor tweak. 1c9ea9ed Fix further problems with padding in PKCS PIVX-Project#1.5 (no surprise). 83de89f7 Remove MSVC support for GMP. 02aba9fe Tweaks to GMP support. 5351e3ae Refactor fast reduction. 08b56edb Try more variants of GMP library name. 70f78c5e Final attempt before giving up. f2e4760b Be more flexible with library names. ad171c69 More details. e823206f Be more descriptive about GMP location. f0c10739 Going back to bash. e55d01a7 Swap vcpkg commands. 53d495d9 Try to fix path. 7ce334de Windows uses backslash for dirs. d32bded0 Try PowerShell now. 66de6363 Another attempt 78e74773 Try to fix include path for MSVC compilation. 924c20ea Another fix. 1f83fcca Fix hierarchy. d724e5a8 Debug MSVC GMP install. d562ed73 Again. 7bf116f7 Possible fix. 3e8f9e53 Another try. 1d368812 Fix typo. 54f857a0 Rename action. dbc38931 Experiment with a different configuration. ae4e09f4 (Much) Faster subgroup checks for BLS12 curves. aca5315e Try to run CI on all branches. 0bfc2550 Be less dramatic about errors. 3a23142b Bump BLAKE2S to latest version. 8c030a57 Faster scalar multiplication in G2. 6e333f2a Make gt_exp_dig into a function and optimize subgroup membership more. 6d2901f2 Save some lines. :) e1c2c139 Fix more problems with mem alloc. 840ea8fa More memory alloc. babcb1b1 Memory allocation again. fcbfcc69 Formatting and speedups. f07f43ba Implement version with private inputs as well. 346af38d Formatting. 57ff4bd4 Exploit multi-pairing. 57f0c8ad Make date accurate. 03b9e559 Speedup using multi-pairing. 48125d66 Add pairing delegation protocols. e54b04c9 Better conditional compilation. git-subtree-dir: contrib/relic git-subtree-split: bf37129789c7897f4144fe2f15d0bd2ef8091807
kwvg
added a commit
to kwvg/bls-signatures
that referenced
this pull request
Sep 25, 2024
4140f28e Indentation. 15f82369 Do not ignore GM8 curves. 0e9da713 Fixing bad batch-rename. 3810062a Now it works! 9c03fcc8 Another try. 26c0d147 More fixes. 60f3dab1 Fix. d0564f82 Cycle counter for Apple M1. 94fc34cc Add support to AArch64. b915b6e7 Merge pull request Chia-Network#249 from fominok/fix-unnecessary-setjmp-include 19b2a6c4 fix: include order 5764793a fix: add ifdef for setjmp include c81ba67f Fix date and formatting. 01ee0d0c Typo. 234a0347 Make lazy reduction less agressive. 9a328da1 Add script to iterate through all pairing configurations. 472ee41b Limit extension degree to test/benchmark, generalize extension field arithmetic a bit. 2ffceecc Reach a better middle-ground. 4674dbd3 Simplify code further by removing corner cases. 1226cf51 Remove deprecated piece of ASM. 8082337c One missing place. dc5ec29f Remove fp2_mulc_low() to simplify code and obtain performance. 72657a6c Fix silly bug in reading char 2 polys. 249bfa0e Reduce code duplication in string parsing. 97556e0d Small speedup. d3ea4ceb Bug fix. 109d4422 Make CMLHS more flexible and more const for signature schemes. f506551d Adjust CMLHS benchmarking. 15f035ee Fix padding issue in benchmarks. 877a7b97 Remove printing artifact. d57ec586 Update demo program. 258a52f0 Add type casts. c0d6e3bf Adjust API update. e605e8b9 Make membership test in G2 more conservative. 8ec2d24a Add SSS benchmarks and adjust Lagrange prototypes. 329c83f5 Handle case when g2 == 0, next do it in constant time. fdd77ad4 Throw error when trying to invert 0. 83502818 Now fix for encryption. be9c2632 Bump library version. eb559cd8 Fix BC sign error. 40f24f01 Fix compile error. a73e819c Add extra checks for division by zero. d7dcb228 Better comment. df6c55ee Faster subgroup membership tests. ce57d38b More const stuff. f4333169 Fix prototype. f1ab6d9e Fix const issues. d5d86887 Use const and size_t more. 978420c2 Merge pull request Chia-Network#226 from jgdumas/rand_constmod b15b94d8 Update makefile. a955e8cf Add preset and fix comments. e36acde8 Merge branch 'main' into rand_constmod 830506d2 Merge pull request Chia-Network#240 from tarakby/permute-optimize 695ed3f1 fix the loop end 3fe3bb8f merge array initialization with permutation 4fdc29ba Reverting due to API issues with compression. 1e420db4 Added BLS12-317 curve. ceb475bc One more test for BGN. cd5ded73 Fix referencing on EP4. 260c379c Remove dependence on fp4_sub_dig(). 4dd709b6 Minor touches to preset and EP4. 62fc88dc Add missing stuff to LABEL support. be47a13b Add missing function for LABEL support. 26cb4d1b Faster final exponentiation for BLS24 curves. f2c65889 Minor adjustments. 7797e082 Added BLS24-315 curve and refactoring of backends. 77880ada Fix comment for precision. 700d0d3c Define missing macro. c2c2ad25 Slightly faster final exponentiation in BLS12. c65ae21a Add BLS12-377 curve. 417c5c55 Handle negative values better and add tests (closes Chia-Network#237 again) 70874a48 Reduce restrictions for modular reduction. 24226360 Handle corner cases with negative moduli better (closes Chia-Network#237) f7ea6d64 Handle negative inputs correctly in Lehmer's GCD (close Chia-Network#236). 277a4f02 Parse negative zero correctly (closes Chia-Network#235). 77c37c65 Make linking hacks Mac-specific. c71eaf25 Hardcoded link library path (Mac OS X is weird). 5e5f2c63 Restore OpenMP library linking. b0356fed Add hardcoded include dir. 22969590 Update multi for MacOS. 821d03a8 One more fix. 8c35f31c Fix silly bug in memory alloc. 6d776c73 Fixed memory allocation problem. 8956634c Revert bad idea of moving asm macro here. 1f349b1d Faster `ep2_mul_sim()` using signed representation. a54febf0 PSI optimizaitons. 3e57eba8 Fix free. 90de7630 Switch to dynamic allocation. c34f9709 Better formatting. 6f0de20b Simpler implementation by hardcoding CRS in both sender/receiver. e535105e Only warmup if running multiple benchmarks. 128a11a3 Include parameters from file. f2461dd1 Add one-shot benchmarks. dffc0a86 Further adjustment to the PSI API. 051c7768 Fix Makefile. b10c4761 Add Makefile for demo. 544a0dff Better formatting for PSI benchmarks and new demo. 32eadbdc Avoid cheating on the receiver side. 49bfcaf7 Restoring. eee15016 Trying brew now. d8c85b1f Typo 81365298 Change MacOS environment. 432842d8 Fix compiler switch for Mac OS X. 36f6d932 Trying again. 8d77cf3f Windows is fixed, now Mac OS X. 99a20984 Another attempt at fixing OpenMP in Windows+MAC OS X. fab8e8f2 Fix MULTI=PTHREAD, remove unnecessary linking libs, try to fix MACOSX. 70f2cd66 Uniformize CMake syntax. f4007317 Try again to fix MULTI on Windows. dd3beabc Avoid segmentation faults when core is not initialized. a4e2f865 Better formatting. 3563cb20 Another corner case. f52f80eb Add multithreading target. 384468a2 Fix allocation of intermediate value in Barrett. 3465cfbb Renamed rlc_thread for Windows compatibility. 87cb5953 Fall back to long division if input to Barreto reduction is out of bounds. 69cdd9f2 Fix corner case for reduction modulo 0 in Chia-Network#221. 67590b0e Align preset with the rest. 7cc79d68 Merge branch 'main' into rand_constmod b12da5fa Improve multithreading configuration a bit. 2225e601 Move global pointer to context. 4d2c2b40 Uniformize SHI-PSI and RSA-PSI rounds and statistical security. 7ef3af9e Minor speedups. 0594e94c Refactor CRT support. 7a9ec0f8 Simplify code when e = NULL. bfa06d2f Another try. 94e5653d Minor refactoring of GCD config/algorithms. 47bb7e61 Avoid overflow in bn_rand_mod(). 280b1425 Memory bugs. 1c3d0e92 Memory fix. 180b6892 Update label support. a483dfc7 Restore tests. e3a1af19 Add SHI-PSI protocol, fix tests/benchmarks. 4b7ea245 Implement SHI-PSI protocol. 0e2c4099 Implement permutation within PSI protocols. 58e5c939 Add permutation generation algorithm. f4f840db Better error handling. 1738af46 Better error handling. b15ba275 More accumulator-based PSI protocols. b4088e48 Remove compilation warnings. fa52ec13 put bac kconst on _add 239ee3ae Merge branch 'main' into rand_constmod a019a5ef Measure new function as well. c72e80ec Add homomorphic addition function to PHPE. 9db54243 Allow SSS with threshold of 2. e927c68e Merge branch 'main' into rand_constmod af77aefa Identation. 0a193b72 Restore benchmarks. 70ca8223 Swap G1 and G2 in Laconic PSI protocol. 8355662d Make WITH=ALL. 6d6d289f Merge branch 'main' into rand_constmod 02913670 Minor polish. addd1f26 Fix Shamir's Secret Sharing and memory alloc issue in ETRS. 6e05783c Merge branch 'main' into rand_constmod 526e295c Large rename to match library standard. 37714c3f Minor adjustments to tests. a3875035 Reorganize implementation to use the crt_t type and save some lines of code. 1b782d01 Added first version of Shamir's Secret Sharing. 0a03f11a _print/_size const e3ad5def _low const f822fbeb oups one const too much d762fe6b _fpx const !!! 00200c9e _enc /_dec const 75b6cbf0 print cmp const fce082f1 is_infty const 48e6f001 more const _mul a223bc4e const _mul 434b1ad5 const _add f377c5a6 const in _map 0e6218cf const in cmp/copy a7d78dc6 more const in g?_mul/exp bfcc28fe more const be5c72a6 modulus should be const in rand_mod? 211c3b9d Merge pull request Chia-Network#225 from jgdumas/shpe ba1806ea forgot ->g 6bb15578 inverted p <--> q 1975412f test divisibility in gen factor prime cea524e3 lower case dce585ef put back "protocols from ECC" 6ce0271c Merge branch 'main' into shpe 19bea45f Subgroup Paillier Cryptosystem, bench and test b3776b79 Merge pull request Chia-Network#224 from jgdumas/phpe 0e8509f1 start cp_shpe 198dbec9 comment in include now 3433feb2 bn_gen_factor_prime in header 74209819 Prime generation with prime factor of (p-1) b969060e comment 3fc3232e If g=1+n, save one of the two exponentiations of phpe encryption 394b3d78 With g=1+n, dp and dq can be computed without any exponentiations This should be faster 058a73c9 Test also gt_exp_gen 6309986f Adjust Bezout coefficients and tweak the algorithm (closes Chia-Network#223) fe61f2f9 Hope it's correct now. 9e523429 Fix endos again. 0775da6e Memory issue. 8736a422 Fix endormorphisms. 1f30423e Fix presets. 35ab6d73 Remove these, as they are not needed anymore. 98e4f129 Refactor of Lagrande interpolation. 3350fbfd Minor speedup with simultaneous inversion. 6c18368b Handle upper/lower case in backends a bit better. 1009a1c2 Remove warnings. dea2a3a4 Fix compilation issue. cffbdae9 Simplify subgroup membership tests. 202d9fd2 Several optimizations for ED module and ETRS scheme. bf371297 Merge pull request Chia-Network#219 from Fuzzbawls/2022_remove-redundant-decls ddaeb28a Remove redundant declarations in relic_fpx.h 97081d11 Minor speedup in LaPSI with cool trick on the exponent. 4107d14c Update LABEL support. 499a65a1 Better test and fixed memm alloc issue for PSI. bbe8963e Memory allocation issue. a3533dde Addind pairing-based PSI protocol. e1b388a0 Trim bn_t at the end of copy. 8930b261 Restore benchmarks. e9c681ab Fix bugs in EXTND coordinate system. 49b2a0d1 Respect STRIP. a953d385 Fix symbol name. 5260f210 Build with stripping enabled. 4848f27d Fix problems with compression and blinding on EDDIE. e4dd23d3 Remove redundant assignment. 50935c18 One more fix for EDDIE. 01433d7f Do not zero buffers without need. 2601df77 Make EDDIE compile with STRIP again. 6d29b274 Share more code between jumpdivstep inversion/symbol. 0f4a481f Refactoring of jumpdivstep inversion/symbol to share code. f333841c Add missing present. cb488ee4 Fix preset. 842cb1f8 Giving up again, problem is with GNU as and our macros. 970fac17 Trying again... 5d26c6a8 Fix typo. eb09222d Another attempt at MacOS integration. 83090950 Merge pull request Chia-Network#216 from feandalo/patch-1 64a5e5e0 Update README.md c56f2cc3 Remove MacOS for a while due to GCC shenanigans. 4a5b2527 Trying another compiler for MacOS. 052c1bf6 Fix artifact of the previous merge. f8431f32 Fix syntax. 7d269435 Reorder CMake commands to see if config works. bb278393 Merge pull request Chia-Network#215 from relic-toolkit/symbol 30f5b659 Fix signal on symbol computation as well. 9a001ec7 Fix for small limb sizes. 896022b3 Formatting. 2f081928 Fixed another bug in bn_mul2_low(). 0c50b590 Another bug fixed. a54c32c5 Fix carry issue in shifting functions. 06cff1fa Update LABEL support with new symbol functions. 37af1f4a Clarify this little hack. 0fce7d3f Merge branch 'main' into symbol 5ffc7f8c Fix bugs with divstep config and return value. 536422ad Update interface of the BN symbol functions. c274e2b2 Update presets to complete configuration. 6c046a07 Better formatting. e7a15a36 Remove compilation warning. 11592073 Add more missing files for Legendre. 6a2d8b9b Benchmark missing algorithm. f5f36c07 Add another missing file, fix dates. b7bbfa11 Fix default low-level implementation of Legendre. a545d806 Add missing file. f21d15ca Refactor configuration to include Legendre symbol, improve tests/bench. d4747b69 Remove warning. 0b49c334 Fixed bug when prime is close to power of 2. b06d27e5 Fix documentation of EP methods. 63aa2e29 Bump version for new future release. a269b6db Fix allocation issue. 4ae9c899 Adjust batch size. 66993770 Simplify API and optimize constant-time execution. e3f82e36 Rename workflow run. 0be5e47d Remove warning. df5ce77a Restore commented out function. f1688dd4 Replace dbl_t type with macros. ab40d2f6 Fix typo. 24602b1b Add missing tests, label and benchmarks. bb5a5dba Refactor divstep-based inversion. 1c6ef422 Fix type. 975573ee New jacobi symbol algorithm. acdcf436 Merge pull request Chia-Network#213 from lorenzcat/main 3ab3a08f Fix NETBSD definition 260c9f8b More bug fixes involving inputs/outputs and corner cases for scalars. ecaf98f9 Fix regression. 72e5652a Improve coverage of corner cases in tests. a001e3e0 Simplify handling of scalars out of bounds. 7bc1d747 Make outputs independent of inputs. 156156a5 Fix sign bug in ep2_mul_sim_lot(). 729bbc18 Fix LABEL and add GH Action for detecting regressions. a33d45bd Add SMLERS. dc851e38 Better printing. cb2075dd Simplify code. 06f30d89 Update demo. edd1aa0c Fix more. 89609c9e Fix compile error. cf3a82a7 Add SMLERS and generalize SoK protocol. 64523296 Add bn_mod_inv_sim(), tests and benchmarks. 42790a02 Fix for ED module. 7a80c3e2 Improve documentation and flexibility of ep_mul_sim_lot(). edf5bd94 Merge branch 'main' of github.com:relic-toolkit/relic 804e5b7f Fix compile error with LABEL. 46742aef Add new algorithm. 2f0273c5 Minor fixes. f49ae035 More conservative optimization. 7fb584fa Add new symbol computations, more work to be done on the API. git-subtree-dir: depends/relic git-subtree-split: 4140f28e9acb19081f522fe5595d3ddd769ee686
kwvg
added a commit
to kwvg/bls-signatures
that referenced
this pull request
Oct 4, 2024
4140f28e Indentation. 15f82369 Do not ignore GM8 curves. 0e9da713 Fixing bad batch-rename. 3810062a Now it works! 9c03fcc8 Another try. 26c0d147 More fixes. 60f3dab1 Fix. d0564f82 Cycle counter for Apple M1. 94fc34cc Add support to AArch64. b915b6e7 Merge pull request Chia-Network#249 from fominok/fix-unnecessary-setjmp-include 19b2a6c4 fix: include order 5764793a fix: add ifdef for setjmp include c81ba67f Fix date and formatting. 01ee0d0c Typo. 234a0347 Make lazy reduction less agressive. 9a328da1 Add script to iterate through all pairing configurations. 472ee41b Limit extension degree to test/benchmark, generalize extension field arithmetic a bit. 2ffceecc Reach a better middle-ground. 4674dbd3 Simplify code further by removing corner cases. 1226cf51 Remove deprecated piece of ASM. 8082337c One missing place. dc5ec29f Remove fp2_mulc_low() to simplify code and obtain performance. 72657a6c Fix silly bug in reading char 2 polys. 249bfa0e Reduce code duplication in string parsing. 97556e0d Small speedup. d3ea4ceb Bug fix. 109d4422 Make CMLHS more flexible and more const for signature schemes. f506551d Adjust CMLHS benchmarking. 15f035ee Fix padding issue in benchmarks. 877a7b97 Remove printing artifact. d57ec586 Update demo program. 258a52f0 Add type casts. c0d6e3bf Adjust API update. e605e8b9 Make membership test in G2 more conservative. 8ec2d24a Add SSS benchmarks and adjust Lagrange prototypes. 329c83f5 Handle case when g2 == 0, next do it in constant time. fdd77ad4 Throw error when trying to invert 0. 83502818 Now fix for encryption. be9c2632 Bump library version. eb559cd8 Fix BC sign error. 40f24f01 Fix compile error. a73e819c Add extra checks for division by zero. d7dcb228 Better comment. df6c55ee Faster subgroup membership tests. ce57d38b More const stuff. f4333169 Fix prototype. f1ab6d9e Fix const issues. d5d86887 Use const and size_t more. 978420c2 Merge pull request Chia-Network#226 from jgdumas/rand_constmod b15b94d8 Update makefile. a955e8cf Add preset and fix comments. e36acde8 Merge branch 'main' into rand_constmod 830506d2 Merge pull request Chia-Network#240 from tarakby/permute-optimize 695ed3f1 fix the loop end 3fe3bb8f merge array initialization with permutation 4fdc29ba Reverting due to API issues with compression. 1e420db4 Added BLS12-317 curve. ceb475bc One more test for BGN. cd5ded73 Fix referencing on EP4. 260c379c Remove dependence on fp4_sub_dig(). 4dd709b6 Minor touches to preset and EP4. 62fc88dc Add missing stuff to LABEL support. be47a13b Add missing function for LABEL support. 26cb4d1b Faster final exponentiation for BLS24 curves. f2c65889 Minor adjustments. 7797e082 Added BLS24-315 curve and refactoring of backends. 77880ada Fix comment for precision. 700d0d3c Define missing macro. c2c2ad25 Slightly faster final exponentiation in BLS12. c65ae21a Add BLS12-377 curve. 417c5c55 Handle negative values better and add tests (closes Chia-Network#237 again) 70874a48 Reduce restrictions for modular reduction. 24226360 Handle corner cases with negative moduli better (closes Chia-Network#237) f7ea6d64 Handle negative inputs correctly in Lehmer's GCD (close Chia-Network#236). 277a4f02 Parse negative zero correctly (closes Chia-Network#235). 77c37c65 Make linking hacks Mac-specific. c71eaf25 Hardcoded link library path (Mac OS X is weird). 5e5f2c63 Restore OpenMP library linking. b0356fed Add hardcoded include dir. 22969590 Update multi for MacOS. 821d03a8 One more fix. 8c35f31c Fix silly bug in memory alloc. 6d776c73 Fixed memory allocation problem. 8956634c Revert bad idea of moving asm macro here. 1f349b1d Faster `ep2_mul_sim()` using signed representation. a54febf0 PSI optimizaitons. 3e57eba8 Fix free. 90de7630 Switch to dynamic allocation. c34f9709 Better formatting. 6f0de20b Simpler implementation by hardcoding CRS in both sender/receiver. e535105e Only warmup if running multiple benchmarks. 128a11a3 Include parameters from file. f2461dd1 Add one-shot benchmarks. dffc0a86 Further adjustment to the PSI API. 051c7768 Fix Makefile. b10c4761 Add Makefile for demo. 544a0dff Better formatting for PSI benchmarks and new demo. 32eadbdc Avoid cheating on the receiver side. 49bfcaf7 Restoring. eee15016 Trying brew now. d8c85b1f Typo 81365298 Change MacOS environment. 432842d8 Fix compiler switch for Mac OS X. 36f6d932 Trying again. 8d77cf3f Windows is fixed, now Mac OS X. 99a20984 Another attempt at fixing OpenMP in Windows+MAC OS X. fab8e8f2 Fix MULTI=PTHREAD, remove unnecessary linking libs, try to fix MACOSX. 70f2cd66 Uniformize CMake syntax. f4007317 Try again to fix MULTI on Windows. dd3beabc Avoid segmentation faults when core is not initialized. a4e2f865 Better formatting. 3563cb20 Another corner case. f52f80eb Add multithreading target. 384468a2 Fix allocation of intermediate value in Barrett. 3465cfbb Renamed rlc_thread for Windows compatibility. 87cb5953 Fall back to long division if input to Barreto reduction is out of bounds. 69cdd9f2 Fix corner case for reduction modulo 0 in Chia-Network#221. 67590b0e Align preset with the rest. 7cc79d68 Merge branch 'main' into rand_constmod b12da5fa Improve multithreading configuration a bit. 2225e601 Move global pointer to context. 4d2c2b40 Uniformize SHI-PSI and RSA-PSI rounds and statistical security. 7ef3af9e Minor speedups. 0594e94c Refactor CRT support. 7a9ec0f8 Simplify code when e = NULL. bfa06d2f Another try. 94e5653d Minor refactoring of GCD config/algorithms. 47bb7e61 Avoid overflow in bn_rand_mod(). 280b1425 Memory bugs. 1c3d0e92 Memory fix. 180b6892 Update label support. a483dfc7 Restore tests. e3a1af19 Add SHI-PSI protocol, fix tests/benchmarks. 4b7ea245 Implement SHI-PSI protocol. 0e2c4099 Implement permutation within PSI protocols. 58e5c939 Add permutation generation algorithm. f4f840db Better error handling. 1738af46 Better error handling. b15ba275 More accumulator-based PSI protocols. b4088e48 Remove compilation warnings. fa52ec13 put bac kconst on _add 239ee3ae Merge branch 'main' into rand_constmod a019a5ef Measure new function as well. c72e80ec Add homomorphic addition function to PHPE. 9db54243 Allow SSS with threshold of 2. e927c68e Merge branch 'main' into rand_constmod af77aefa Identation. 0a193b72 Restore benchmarks. 70ca8223 Swap G1 and G2 in Laconic PSI protocol. 8355662d Make WITH=ALL. 6d6d289f Merge branch 'main' into rand_constmod 02913670 Minor polish. addd1f26 Fix Shamir's Secret Sharing and memory alloc issue in ETRS. 6e05783c Merge branch 'main' into rand_constmod 526e295c Large rename to match library standard. 37714c3f Minor adjustments to tests. a3875035 Reorganize implementation to use the crt_t type and save some lines of code. 1b782d01 Added first version of Shamir's Secret Sharing. 0a03f11a _print/_size const e3ad5def _low const f822fbeb oups one const too much d762fe6b _fpx const !!! 00200c9e _enc /_dec const 75b6cbf0 print cmp const fce082f1 is_infty const 48e6f001 more const _mul a223bc4e const _mul 434b1ad5 const _add f377c5a6 const in _map 0e6218cf const in cmp/copy a7d78dc6 more const in g?_mul/exp bfcc28fe more const be5c72a6 modulus should be const in rand_mod? 211c3b9d Merge pull request Chia-Network#225 from jgdumas/shpe ba1806ea forgot ->g 6bb15578 inverted p <--> q 1975412f test divisibility in gen factor prime cea524e3 lower case dce585ef put back "protocols from ECC" 6ce0271c Merge branch 'main' into shpe 19bea45f Subgroup Paillier Cryptosystem, bench and test b3776b79 Merge pull request Chia-Network#224 from jgdumas/phpe 0e8509f1 start cp_shpe 198dbec9 comment in include now 3433feb2 bn_gen_factor_prime in header 74209819 Prime generation with prime factor of (p-1) b969060e comment 3fc3232e If g=1+n, save one of the two exponentiations of phpe encryption 394b3d78 With g=1+n, dp and dq can be computed without any exponentiations This should be faster 058a73c9 Test also gt_exp_gen 6309986f Adjust Bezout coefficients and tweak the algorithm (closes Chia-Network#223) fe61f2f9 Hope it's correct now. 9e523429 Fix endos again. 0775da6e Memory issue. 8736a422 Fix endormorphisms. 1f30423e Fix presets. 35ab6d73 Remove these, as they are not needed anymore. 98e4f129 Refactor of Lagrande interpolation. 3350fbfd Minor speedup with simultaneous inversion. 6c18368b Handle upper/lower case in backends a bit better. 1009a1c2 Remove warnings. dea2a3a4 Fix compilation issue. cffbdae9 Simplify subgroup membership tests. 202d9fd2 Several optimizations for ED module and ETRS scheme. bf371297 Merge pull request Chia-Network#219 from Fuzzbawls/2022_remove-redundant-decls ddaeb28a Remove redundant declarations in relic_fpx.h 97081d11 Minor speedup in LaPSI with cool trick on the exponent. 4107d14c Update LABEL support. 499a65a1 Better test and fixed memm alloc issue for PSI. bbe8963e Memory allocation issue. a3533dde Addind pairing-based PSI protocol. e1b388a0 Trim bn_t at the end of copy. 8930b261 Restore benchmarks. e9c681ab Fix bugs in EXTND coordinate system. 49b2a0d1 Respect STRIP. a953d385 Fix symbol name. 5260f210 Build with stripping enabled. 4848f27d Fix problems with compression and blinding on EDDIE. e4dd23d3 Remove redundant assignment. 50935c18 One more fix for EDDIE. 01433d7f Do not zero buffers without need. 2601df77 Make EDDIE compile with STRIP again. 6d29b274 Share more code between jumpdivstep inversion/symbol. 0f4a481f Refactoring of jumpdivstep inversion/symbol to share code. f333841c Add missing present. cb488ee4 Fix preset. 842cb1f8 Giving up again, problem is with GNU as and our macros. 970fac17 Trying again... 5d26c6a8 Fix typo. eb09222d Another attempt at MacOS integration. 83090950 Merge pull request Chia-Network#216 from feandalo/patch-1 64a5e5e0 Update README.md c56f2cc3 Remove MacOS for a while due to GCC shenanigans. 4a5b2527 Trying another compiler for MacOS. 052c1bf6 Fix artifact of the previous merge. f8431f32 Fix syntax. 7d269435 Reorder CMake commands to see if config works. bb278393 Merge pull request Chia-Network#215 from relic-toolkit/symbol 30f5b659 Fix signal on symbol computation as well. 9a001ec7 Fix for small limb sizes. 896022b3 Formatting. 2f081928 Fixed another bug in bn_mul2_low(). 0c50b590 Another bug fixed. a54c32c5 Fix carry issue in shifting functions. 06cff1fa Update LABEL support with new symbol functions. 37af1f4a Clarify this little hack. 0fce7d3f Merge branch 'main' into symbol 5ffc7f8c Fix bugs with divstep config and return value. 536422ad Update interface of the BN symbol functions. c274e2b2 Update presets to complete configuration. 6c046a07 Better formatting. e7a15a36 Remove compilation warning. 11592073 Add more missing files for Legendre. 6a2d8b9b Benchmark missing algorithm. f5f36c07 Add another missing file, fix dates. b7bbfa11 Fix default low-level implementation of Legendre. a545d806 Add missing file. f21d15ca Refactor configuration to include Legendre symbol, improve tests/bench. d4747b69 Remove warning. 0b49c334 Fixed bug when prime is close to power of 2. b06d27e5 Fix documentation of EP methods. 63aa2e29 Bump version for new future release. a269b6db Fix allocation issue. 4ae9c899 Adjust batch size. 66993770 Simplify API and optimize constant-time execution. e3f82e36 Rename workflow run. 0be5e47d Remove warning. df5ce77a Restore commented out function. f1688dd4 Replace dbl_t type with macros. ab40d2f6 Fix typo. 24602b1b Add missing tests, label and benchmarks. bb5a5dba Refactor divstep-based inversion. 1c6ef422 Fix type. 975573ee New jacobi symbol algorithm. acdcf436 Merge pull request Chia-Network#213 from lorenzcat/main 3ab3a08f Fix NETBSD definition 260c9f8b More bug fixes involving inputs/outputs and corner cases for scalars. ecaf98f9 Fix regression. 72e5652a Improve coverage of corner cases in tests. a001e3e0 Simplify handling of scalars out of bounds. 7bc1d747 Make outputs independent of inputs. 156156a5 Fix sign bug in ep2_mul_sim_lot(). 729bbc18 Fix LABEL and add GH Action for detecting regressions. a33d45bd Add SMLERS. dc851e38 Better printing. cb2075dd Simplify code. 06f30d89 Update demo. edd1aa0c Fix more. 89609c9e Fix compile error. cf3a82a7 Add SMLERS and generalize SoK protocol. 64523296 Add bn_mod_inv_sim(), tests and benchmarks. 42790a02 Fix for ED module. 7a80c3e2 Improve documentation and flexibility of ep_mul_sim_lot(). edf5bd94 Merge branch 'main' of github.com:relic-toolkit/relic 804e5b7f Fix compile error with LABEL. 46742aef Add new algorithm. 2f0273c5 Minor fixes. f49ae035 More conservative optimization. 7fb584fa Add new symbol computations, more work to be done on the API. git-subtree-dir: depends/relic git-subtree-split: 4140f28e9acb19081f522fe5595d3ddd769ee686
kwvg
added a commit
to kwvg/bls-signatures
that referenced
this pull request
Oct 4, 2024
4140f28e Indentation. 15f82369 Do not ignore GM8 curves. 0e9da713 Fixing bad batch-rename. 3810062a Now it works! 9c03fcc8 Another try. 26c0d147 More fixes. 60f3dab1 Fix. d0564f82 Cycle counter for Apple M1. 94fc34cc Add support to AArch64. b915b6e7 Merge pull request Chia-Network#249 from fominok/fix-unnecessary-setjmp-include 19b2a6c4 fix: include order 5764793a fix: add ifdef for setjmp include c81ba67f Fix date and formatting. 01ee0d0c Typo. 234a0347 Make lazy reduction less agressive. 9a328da1 Add script to iterate through all pairing configurations. 472ee41b Limit extension degree to test/benchmark, generalize extension field arithmetic a bit. 2ffceecc Reach a better middle-ground. 4674dbd3 Simplify code further by removing corner cases. 1226cf51 Remove deprecated piece of ASM. 8082337c One missing place. dc5ec29f Remove fp2_mulc_low() to simplify code and obtain performance. 72657a6c Fix silly bug in reading char 2 polys. 249bfa0e Reduce code duplication in string parsing. 97556e0d Small speedup. d3ea4ceb Bug fix. 109d4422 Make CMLHS more flexible and more const for signature schemes. f506551d Adjust CMLHS benchmarking. 15f035ee Fix padding issue in benchmarks. 877a7b97 Remove printing artifact. d57ec586 Update demo program. 258a52f0 Add type casts. c0d6e3bf Adjust API update. e605e8b9 Make membership test in G2 more conservative. 8ec2d24a Add SSS benchmarks and adjust Lagrange prototypes. 329c83f5 Handle case when g2 == 0, next do it in constant time. fdd77ad4 Throw error when trying to invert 0. 83502818 Now fix for encryption. be9c2632 Bump library version. eb559cd8 Fix BC sign error. 40f24f01 Fix compile error. a73e819c Add extra checks for division by zero. d7dcb228 Better comment. df6c55ee Faster subgroup membership tests. ce57d38b More const stuff. f4333169 Fix prototype. f1ab6d9e Fix const issues. d5d86887 Use const and size_t more. 978420c2 Merge pull request Chia-Network#226 from jgdumas/rand_constmod b15b94d8 Update makefile. a955e8cf Add preset and fix comments. e36acde8 Merge branch 'main' into rand_constmod 830506d2 Merge pull request Chia-Network#240 from tarakby/permute-optimize 695ed3f1 fix the loop end 3fe3bb8f merge array initialization with permutation 4fdc29ba Reverting due to API issues with compression. 1e420db4 Added BLS12-317 curve. ceb475bc One more test for BGN. cd5ded73 Fix referencing on EP4. 260c379c Remove dependence on fp4_sub_dig(). 4dd709b6 Minor touches to preset and EP4. 62fc88dc Add missing stuff to LABEL support. be47a13b Add missing function for LABEL support. 26cb4d1b Faster final exponentiation for BLS24 curves. f2c65889 Minor adjustments. 7797e082 Added BLS24-315 curve and refactoring of backends. 77880ada Fix comment for precision. 700d0d3c Define missing macro. c2c2ad25 Slightly faster final exponentiation in BLS12. c65ae21a Add BLS12-377 curve. 417c5c55 Handle negative values better and add tests (closes Chia-Network#237 again) 70874a48 Reduce restrictions for modular reduction. 24226360 Handle corner cases with negative moduli better (closes Chia-Network#237) f7ea6d64 Handle negative inputs correctly in Lehmer's GCD (close Chia-Network#236). 277a4f02 Parse negative zero correctly (closes Chia-Network#235). 77c37c65 Make linking hacks Mac-specific. c71eaf25 Hardcoded link library path (Mac OS X is weird). 5e5f2c63 Restore OpenMP library linking. b0356fed Add hardcoded include dir. 22969590 Update multi for MacOS. 821d03a8 One more fix. 8c35f31c Fix silly bug in memory alloc. 6d776c73 Fixed memory allocation problem. 8956634c Revert bad idea of moving asm macro here. 1f349b1d Faster `ep2_mul_sim()` using signed representation. a54febf0 PSI optimizaitons. 3e57eba8 Fix free. 90de7630 Switch to dynamic allocation. c34f9709 Better formatting. 6f0de20b Simpler implementation by hardcoding CRS in both sender/receiver. e535105e Only warmup if running multiple benchmarks. 128a11a3 Include parameters from file. f2461dd1 Add one-shot benchmarks. dffc0a86 Further adjustment to the PSI API. 051c7768 Fix Makefile. b10c4761 Add Makefile for demo. 544a0dff Better formatting for PSI benchmarks and new demo. 32eadbdc Avoid cheating on the receiver side. 49bfcaf7 Restoring. eee15016 Trying brew now. d8c85b1f Typo 81365298 Change MacOS environment. 432842d8 Fix compiler switch for Mac OS X. 36f6d932 Trying again. 8d77cf3f Windows is fixed, now Mac OS X. 99a20984 Another attempt at fixing OpenMP in Windows+MAC OS X. fab8e8f2 Fix MULTI=PTHREAD, remove unnecessary linking libs, try to fix MACOSX. 70f2cd66 Uniformize CMake syntax. f4007317 Try again to fix MULTI on Windows. dd3beabc Avoid segmentation faults when core is not initialized. a4e2f865 Better formatting. 3563cb20 Another corner case. f52f80eb Add multithreading target. 384468a2 Fix allocation of intermediate value in Barrett. 3465cfbb Renamed rlc_thread for Windows compatibility. 87cb5953 Fall back to long division if input to Barreto reduction is out of bounds. 69cdd9f2 Fix corner case for reduction modulo 0 in Chia-Network#221. 67590b0e Align preset with the rest. 7cc79d68 Merge branch 'main' into rand_constmod b12da5fa Improve multithreading configuration a bit. 2225e601 Move global pointer to context. 4d2c2b40 Uniformize SHI-PSI and RSA-PSI rounds and statistical security. 7ef3af9e Minor speedups. 0594e94c Refactor CRT support. 7a9ec0f8 Simplify code when e = NULL. bfa06d2f Another try. 94e5653d Minor refactoring of GCD config/algorithms. 47bb7e61 Avoid overflow in bn_rand_mod(). 280b1425 Memory bugs. 1c3d0e92 Memory fix. 180b6892 Update label support. a483dfc7 Restore tests. e3a1af19 Add SHI-PSI protocol, fix tests/benchmarks. 4b7ea245 Implement SHI-PSI protocol. 0e2c4099 Implement permutation within PSI protocols. 58e5c939 Add permutation generation algorithm. f4f840db Better error handling. 1738af46 Better error handling. b15ba275 More accumulator-based PSI protocols. b4088e48 Remove compilation warnings. fa52ec13 put bac kconst on _add 239ee3ae Merge branch 'main' into rand_constmod a019a5ef Measure new function as well. c72e80ec Add homomorphic addition function to PHPE. 9db54243 Allow SSS with threshold of 2. e927c68e Merge branch 'main' into rand_constmod af77aefa Identation. 0a193b72 Restore benchmarks. 70ca8223 Swap G1 and G2 in Laconic PSI protocol. 8355662d Make WITH=ALL. 6d6d289f Merge branch 'main' into rand_constmod 02913670 Minor polish. addd1f26 Fix Shamir's Secret Sharing and memory alloc issue in ETRS. 6e05783c Merge branch 'main' into rand_constmod 526e295c Large rename to match library standard. 37714c3f Minor adjustments to tests. a3875035 Reorganize implementation to use the crt_t type and save some lines of code. 1b782d01 Added first version of Shamir's Secret Sharing. 0a03f11a _print/_size const e3ad5def _low const f822fbeb oups one const too much d762fe6b _fpx const !!! 00200c9e _enc /_dec const 75b6cbf0 print cmp const fce082f1 is_infty const 48e6f001 more const _mul a223bc4e const _mul 434b1ad5 const _add f377c5a6 const in _map 0e6218cf const in cmp/copy a7d78dc6 more const in g?_mul/exp bfcc28fe more const be5c72a6 modulus should be const in rand_mod? 211c3b9d Merge pull request Chia-Network#225 from jgdumas/shpe ba1806ea forgot ->g 6bb15578 inverted p <--> q 1975412f test divisibility in gen factor prime cea524e3 lower case dce585ef put back "protocols from ECC" 6ce0271c Merge branch 'main' into shpe 19bea45f Subgroup Paillier Cryptosystem, bench and test b3776b79 Merge pull request Chia-Network#224 from jgdumas/phpe 0e8509f1 start cp_shpe 198dbec9 comment in include now 3433feb2 bn_gen_factor_prime in header 74209819 Prime generation with prime factor of (p-1) b969060e comment 3fc3232e If g=1+n, save one of the two exponentiations of phpe encryption 394b3d78 With g=1+n, dp and dq can be computed without any exponentiations This should be faster 058a73c9 Test also gt_exp_gen 6309986f Adjust Bezout coefficients and tweak the algorithm (closes Chia-Network#223) fe61f2f9 Hope it's correct now. 9e523429 Fix endos again. 0775da6e Memory issue. 8736a422 Fix endormorphisms. 1f30423e Fix presets. 35ab6d73 Remove these, as they are not needed anymore. 98e4f129 Refactor of Lagrande interpolation. 3350fbfd Minor speedup with simultaneous inversion. 6c18368b Handle upper/lower case in backends a bit better. 1009a1c2 Remove warnings. dea2a3a4 Fix compilation issue. cffbdae9 Simplify subgroup membership tests. 202d9fd2 Several optimizations for ED module and ETRS scheme. bf371297 Merge pull request Chia-Network#219 from Fuzzbawls/2022_remove-redundant-decls ddaeb28a Remove redundant declarations in relic_fpx.h 97081d11 Minor speedup in LaPSI with cool trick on the exponent. 4107d14c Update LABEL support. 499a65a1 Better test and fixed memm alloc issue for PSI. bbe8963e Memory allocation issue. a3533dde Addind pairing-based PSI protocol. e1b388a0 Trim bn_t at the end of copy. 8930b261 Restore benchmarks. e9c681ab Fix bugs in EXTND coordinate system. 49b2a0d1 Respect STRIP. a953d385 Fix symbol name. 5260f210 Build with stripping enabled. 4848f27d Fix problems with compression and blinding on EDDIE. e4dd23d3 Remove redundant assignment. 50935c18 One more fix for EDDIE. 01433d7f Do not zero buffers without need. 2601df77 Make EDDIE compile with STRIP again. 6d29b274 Share more code between jumpdivstep inversion/symbol. 0f4a481f Refactoring of jumpdivstep inversion/symbol to share code. f333841c Add missing present. cb488ee4 Fix preset. 842cb1f8 Giving up again, problem is with GNU as and our macros. 970fac17 Trying again... 5d26c6a8 Fix typo. eb09222d Another attempt at MacOS integration. 83090950 Merge pull request Chia-Network#216 from feandalo/patch-1 64a5e5e0 Update README.md c56f2cc3 Remove MacOS for a while due to GCC shenanigans. 4a5b2527 Trying another compiler for MacOS. 052c1bf6 Fix artifact of the previous merge. f8431f32 Fix syntax. 7d269435 Reorder CMake commands to see if config works. bb278393 Merge pull request Chia-Network#215 from relic-toolkit/symbol 30f5b659 Fix signal on symbol computation as well. 9a001ec7 Fix for small limb sizes. 896022b3 Formatting. 2f081928 Fixed another bug in bn_mul2_low(). 0c50b590 Another bug fixed. a54c32c5 Fix carry issue in shifting functions. 06cff1fa Update LABEL support with new symbol functions. 37af1f4a Clarify this little hack. 0fce7d3f Merge branch 'main' into symbol 5ffc7f8c Fix bugs with divstep config and return value. 536422ad Update interface of the BN symbol functions. c274e2b2 Update presets to complete configuration. 6c046a07 Better formatting. e7a15a36 Remove compilation warning. 11592073 Add more missing files for Legendre. 6a2d8b9b Benchmark missing algorithm. f5f36c07 Add another missing file, fix dates. b7bbfa11 Fix default low-level implementation of Legendre. a545d806 Add missing file. f21d15ca Refactor configuration to include Legendre symbol, improve tests/bench. d4747b69 Remove warning. 0b49c334 Fixed bug when prime is close to power of 2. b06d27e5 Fix documentation of EP methods. 63aa2e29 Bump version for new future release. a269b6db Fix allocation issue. 4ae9c899 Adjust batch size. 66993770 Simplify API and optimize constant-time execution. e3f82e36 Rename workflow run. 0be5e47d Remove warning. df5ce77a Restore commented out function. f1688dd4 Replace dbl_t type with macros. ab40d2f6 Fix typo. 24602b1b Add missing tests, label and benchmarks. bb5a5dba Refactor divstep-based inversion. 1c6ef422 Fix type. 975573ee New jacobi symbol algorithm. acdcf436 Merge pull request Chia-Network#213 from lorenzcat/main 3ab3a08f Fix NETBSD definition 260c9f8b More bug fixes involving inputs/outputs and corner cases for scalars. ecaf98f9 Fix regression. 72e5652a Improve coverage of corner cases in tests. a001e3e0 Simplify handling of scalars out of bounds. 7bc1d747 Make outputs independent of inputs. 156156a5 Fix sign bug in ep2_mul_sim_lot(). 729bbc18 Fix LABEL and add GH Action for detecting regressions. a33d45bd Add SMLERS. dc851e38 Better printing. cb2075dd Simplify code. 06f30d89 Update demo. edd1aa0c Fix more. 89609c9e Fix compile error. cf3a82a7 Add SMLERS and generalize SoK protocol. 64523296 Add bn_mod_inv_sim(), tests and benchmarks. 42790a02 Fix for ED module. 7a80c3e2 Improve documentation and flexibility of ep_mul_sim_lot(). edf5bd94 Merge branch 'main' of github.com:relic-toolkit/relic 804e5b7f Fix compile error with LABEL. 46742aef Add new algorithm. 2f0273c5 Minor fixes. f49ae035 More conservative optimization. 7fb584fa Add new symbol computations, more work to be done on the API. git-subtree-dir: depends/relic git-subtree-split: 4140f28e9acb19081f522fe5595d3ddd769ee686
kwvg
added a commit
to kwvg/bls-signatures
that referenced
this pull request
Oct 5, 2024
4140f28e Indentation. 15f82369 Do not ignore GM8 curves. 0e9da713 Fixing bad batch-rename. 3810062a Now it works! 9c03fcc8 Another try. 26c0d147 More fixes. 60f3dab1 Fix. d0564f82 Cycle counter for Apple M1. 94fc34cc Add support to AArch64. b915b6e7 Merge pull request Chia-Network#249 from fominok/fix-unnecessary-setjmp-include 19b2a6c4 fix: include order 5764793a fix: add ifdef for setjmp include c81ba67f Fix date and formatting. 01ee0d0c Typo. 234a0347 Make lazy reduction less agressive. 9a328da1 Add script to iterate through all pairing configurations. 472ee41b Limit extension degree to test/benchmark, generalize extension field arithmetic a bit. 2ffceecc Reach a better middle-ground. 4674dbd3 Simplify code further by removing corner cases. 1226cf51 Remove deprecated piece of ASM. 8082337c One missing place. dc5ec29f Remove fp2_mulc_low() to simplify code and obtain performance. 72657a6c Fix silly bug in reading char 2 polys. 249bfa0e Reduce code duplication in string parsing. 97556e0d Small speedup. d3ea4ceb Bug fix. 109d4422 Make CMLHS more flexible and more const for signature schemes. f506551d Adjust CMLHS benchmarking. 15f035ee Fix padding issue in benchmarks. 877a7b97 Remove printing artifact. d57ec586 Update demo program. 258a52f0 Add type casts. c0d6e3bf Adjust API update. e605e8b9 Make membership test in G2 more conservative. 8ec2d24a Add SSS benchmarks and adjust Lagrange prototypes. 329c83f5 Handle case when g2 == 0, next do it in constant time. fdd77ad4 Throw error when trying to invert 0. 83502818 Now fix for encryption. be9c2632 Bump library version. eb559cd8 Fix BC sign error. 40f24f01 Fix compile error. a73e819c Add extra checks for division by zero. d7dcb228 Better comment. df6c55ee Faster subgroup membership tests. ce57d38b More const stuff. f4333169 Fix prototype. f1ab6d9e Fix const issues. d5d86887 Use const and size_t more. 978420c2 Merge pull request Chia-Network#226 from jgdumas/rand_constmod b15b94d8 Update makefile. a955e8cf Add preset and fix comments. e36acde8 Merge branch 'main' into rand_constmod 830506d2 Merge pull request Chia-Network#240 from tarakby/permute-optimize 695ed3f1 fix the loop end 3fe3bb8f merge array initialization with permutation 4fdc29ba Reverting due to API issues with compression. 1e420db4 Added BLS12-317 curve. ceb475bc One more test for BGN. cd5ded73 Fix referencing on EP4. 260c379c Remove dependence on fp4_sub_dig(). 4dd709b6 Minor touches to preset and EP4. 62fc88dc Add missing stuff to LABEL support. be47a13b Add missing function for LABEL support. 26cb4d1b Faster final exponentiation for BLS24 curves. f2c65889 Minor adjustments. 7797e082 Added BLS24-315 curve and refactoring of backends. 77880ada Fix comment for precision. 700d0d3c Define missing macro. c2c2ad25 Slightly faster final exponentiation in BLS12. c65ae21a Add BLS12-377 curve. 417c5c55 Handle negative values better and add tests (closes Chia-Network#237 again) 70874a48 Reduce restrictions for modular reduction. 24226360 Handle corner cases with negative moduli better (closes Chia-Network#237) f7ea6d64 Handle negative inputs correctly in Lehmer's GCD (close Chia-Network#236). 277a4f02 Parse negative zero correctly (closes Chia-Network#235). 77c37c65 Make linking hacks Mac-specific. c71eaf25 Hardcoded link library path (Mac OS X is weird). 5e5f2c63 Restore OpenMP library linking. b0356fed Add hardcoded include dir. 22969590 Update multi for MacOS. 821d03a8 One more fix. 8c35f31c Fix silly bug in memory alloc. 6d776c73 Fixed memory allocation problem. 8956634c Revert bad idea of moving asm macro here. 1f349b1d Faster `ep2_mul_sim()` using signed representation. a54febf0 PSI optimizaitons. 3e57eba8 Fix free. 90de7630 Switch to dynamic allocation. c34f9709 Better formatting. 6f0de20b Simpler implementation by hardcoding CRS in both sender/receiver. e535105e Only warmup if running multiple benchmarks. 128a11a3 Include parameters from file. f2461dd1 Add one-shot benchmarks. dffc0a86 Further adjustment to the PSI API. 051c7768 Fix Makefile. b10c4761 Add Makefile for demo. 544a0dff Better formatting for PSI benchmarks and new demo. 32eadbdc Avoid cheating on the receiver side. 49bfcaf7 Restoring. eee15016 Trying brew now. d8c85b1f Typo 81365298 Change MacOS environment. 432842d8 Fix compiler switch for Mac OS X. 36f6d932 Trying again. 8d77cf3f Windows is fixed, now Mac OS X. 99a20984 Another attempt at fixing OpenMP in Windows+MAC OS X. fab8e8f2 Fix MULTI=PTHREAD, remove unnecessary linking libs, try to fix MACOSX. 70f2cd66 Uniformize CMake syntax. f4007317 Try again to fix MULTI on Windows. dd3beabc Avoid segmentation faults when core is not initialized. a4e2f865 Better formatting. 3563cb20 Another corner case. f52f80eb Add multithreading target. 384468a2 Fix allocation of intermediate value in Barrett. 3465cfbb Renamed rlc_thread for Windows compatibility. 87cb5953 Fall back to long division if input to Barreto reduction is out of bounds. 69cdd9f2 Fix corner case for reduction modulo 0 in Chia-Network#221. 67590b0e Align preset with the rest. 7cc79d68 Merge branch 'main' into rand_constmod b12da5fa Improve multithreading configuration a bit. 2225e601 Move global pointer to context. 4d2c2b40 Uniformize SHI-PSI and RSA-PSI rounds and statistical security. 7ef3af9e Minor speedups. 0594e94c Refactor CRT support. 7a9ec0f8 Simplify code when e = NULL. bfa06d2f Another try. 94e5653d Minor refactoring of GCD config/algorithms. 47bb7e61 Avoid overflow in bn_rand_mod(). 280b1425 Memory bugs. 1c3d0e92 Memory fix. 180b6892 Update label support. a483dfc7 Restore tests. e3a1af19 Add SHI-PSI protocol, fix tests/benchmarks. 4b7ea245 Implement SHI-PSI protocol. 0e2c4099 Implement permutation within PSI protocols. 58e5c939 Add permutation generation algorithm. f4f840db Better error handling. 1738af46 Better error handling. b15ba275 More accumulator-based PSI protocols. b4088e48 Remove compilation warnings. fa52ec13 put bac kconst on _add 239ee3ae Merge branch 'main' into rand_constmod a019a5ef Measure new function as well. c72e80ec Add homomorphic addition function to PHPE. 9db54243 Allow SSS with threshold of 2. e927c68e Merge branch 'main' into rand_constmod af77aefa Identation. 0a193b72 Restore benchmarks. 70ca8223 Swap G1 and G2 in Laconic PSI protocol. 8355662d Make WITH=ALL. 6d6d289f Merge branch 'main' into rand_constmod 02913670 Minor polish. addd1f26 Fix Shamir's Secret Sharing and memory alloc issue in ETRS. 6e05783c Merge branch 'main' into rand_constmod 526e295c Large rename to match library standard. 37714c3f Minor adjustments to tests. a3875035 Reorganize implementation to use the crt_t type and save some lines of code. 1b782d01 Added first version of Shamir's Secret Sharing. 0a03f11a _print/_size const e3ad5def _low const f822fbeb oups one const too much d762fe6b _fpx const !!! 00200c9e _enc /_dec const 75b6cbf0 print cmp const fce082f1 is_infty const 48e6f001 more const _mul a223bc4e const _mul 434b1ad5 const _add f377c5a6 const in _map 0e6218cf const in cmp/copy a7d78dc6 more const in g?_mul/exp bfcc28fe more const be5c72a6 modulus should be const in rand_mod? 211c3b9d Merge pull request Chia-Network#225 from jgdumas/shpe ba1806ea forgot ->g 6bb15578 inverted p <--> q 1975412f test divisibility in gen factor prime cea524e3 lower case dce585ef put back "protocols from ECC" 6ce0271c Merge branch 'main' into shpe 19bea45f Subgroup Paillier Cryptosystem, bench and test b3776b79 Merge pull request Chia-Network#224 from jgdumas/phpe 0e8509f1 start cp_shpe 198dbec9 comment in include now 3433feb2 bn_gen_factor_prime in header 74209819 Prime generation with prime factor of (p-1) b969060e comment 3fc3232e If g=1+n, save one of the two exponentiations of phpe encryption 394b3d78 With g=1+n, dp and dq can be computed without any exponentiations This should be faster 058a73c9 Test also gt_exp_gen 6309986f Adjust Bezout coefficients and tweak the algorithm (closes Chia-Network#223) fe61f2f9 Hope it's correct now. 9e523429 Fix endos again. 0775da6e Memory issue. 8736a422 Fix endormorphisms. 1f30423e Fix presets. 35ab6d73 Remove these, as they are not needed anymore. 98e4f129 Refactor of Lagrande interpolation. 3350fbfd Minor speedup with simultaneous inversion. 6c18368b Handle upper/lower case in backends a bit better. 1009a1c2 Remove warnings. dea2a3a4 Fix compilation issue. cffbdae9 Simplify subgroup membership tests. 202d9fd2 Several optimizations for ED module and ETRS scheme. bf371297 Merge pull request Chia-Network#219 from Fuzzbawls/2022_remove-redundant-decls ddaeb28a Remove redundant declarations in relic_fpx.h 97081d11 Minor speedup in LaPSI with cool trick on the exponent. 4107d14c Update LABEL support. 499a65a1 Better test and fixed memm alloc issue for PSI. bbe8963e Memory allocation issue. a3533dde Addind pairing-based PSI protocol. e1b388a0 Trim bn_t at the end of copy. 8930b261 Restore benchmarks. e9c681ab Fix bugs in EXTND coordinate system. 49b2a0d1 Respect STRIP. a953d385 Fix symbol name. 5260f210 Build with stripping enabled. 4848f27d Fix problems with compression and blinding on EDDIE. e4dd23d3 Remove redundant assignment. 50935c18 One more fix for EDDIE. 01433d7f Do not zero buffers without need. 2601df77 Make EDDIE compile with STRIP again. 6d29b274 Share more code between jumpdivstep inversion/symbol. 0f4a481f Refactoring of jumpdivstep inversion/symbol to share code. f333841c Add missing present. cb488ee4 Fix preset. 842cb1f8 Giving up again, problem is with GNU as and our macros. 970fac17 Trying again... 5d26c6a8 Fix typo. eb09222d Another attempt at MacOS integration. 83090950 Merge pull request Chia-Network#216 from feandalo/patch-1 64a5e5e0 Update README.md c56f2cc3 Remove MacOS for a while due to GCC shenanigans. 4a5b2527 Trying another compiler for MacOS. 052c1bf6 Fix artifact of the previous merge. f8431f32 Fix syntax. 7d269435 Reorder CMake commands to see if config works. bb278393 Merge pull request Chia-Network#215 from relic-toolkit/symbol 30f5b659 Fix signal on symbol computation as well. 9a001ec7 Fix for small limb sizes. 896022b3 Formatting. 2f081928 Fixed another bug in bn_mul2_low(). 0c50b590 Another bug fixed. a54c32c5 Fix carry issue in shifting functions. 06cff1fa Update LABEL support with new symbol functions. 37af1f4a Clarify this little hack. 0fce7d3f Merge branch 'main' into symbol 5ffc7f8c Fix bugs with divstep config and return value. 536422ad Update interface of the BN symbol functions. c274e2b2 Update presets to complete configuration. 6c046a07 Better formatting. e7a15a36 Remove compilation warning. 11592073 Add more missing files for Legendre. 6a2d8b9b Benchmark missing algorithm. f5f36c07 Add another missing file, fix dates. b7bbfa11 Fix default low-level implementation of Legendre. a545d806 Add missing file. f21d15ca Refactor configuration to include Legendre symbol, improve tests/bench. d4747b69 Remove warning. 0b49c334 Fixed bug when prime is close to power of 2. b06d27e5 Fix documentation of EP methods. 63aa2e29 Bump version for new future release. a269b6db Fix allocation issue. 4ae9c899 Adjust batch size. 66993770 Simplify API and optimize constant-time execution. e3f82e36 Rename workflow run. 0be5e47d Remove warning. df5ce77a Restore commented out function. f1688dd4 Replace dbl_t type with macros. ab40d2f6 Fix typo. 24602b1b Add missing tests, label and benchmarks. bb5a5dba Refactor divstep-based inversion. 1c6ef422 Fix type. 975573ee New jacobi symbol algorithm. acdcf436 Merge pull request Chia-Network#213 from lorenzcat/main 3ab3a08f Fix NETBSD definition 260c9f8b More bug fixes involving inputs/outputs and corner cases for scalars. ecaf98f9 Fix regression. 72e5652a Improve coverage of corner cases in tests. a001e3e0 Simplify handling of scalars out of bounds. 7bc1d747 Make outputs independent of inputs. 156156a5 Fix sign bug in ep2_mul_sim_lot(). 729bbc18 Fix LABEL and add GH Action for detecting regressions. a33d45bd Add SMLERS. dc851e38 Better printing. cb2075dd Simplify code. 06f30d89 Update demo. edd1aa0c Fix more. 89609c9e Fix compile error. cf3a82a7 Add SMLERS and generalize SoK protocol. 64523296 Add bn_mod_inv_sim(), tests and benchmarks. 42790a02 Fix for ED module. 7a80c3e2 Improve documentation and flexibility of ep_mul_sim_lot(). edf5bd94 Merge branch 'main' of github.com:relic-toolkit/relic 804e5b7f Fix compile error with LABEL. 46742aef Add new algorithm. 2f0273c5 Minor fixes. f49ae035 More conservative optimization. 7fb584fa Add new symbol computations, more work to be done on the API. git-subtree-dir: depends/relic git-subtree-split: 4140f28e9acb19081f522fe5595d3ddd769ee686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.