Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the development branch of Cpp2IL #533

Merged
merged 6 commits into from
Dec 30, 2022
Merged

Switch to the development branch of Cpp2IL #533

merged 6 commits into from
Dec 30, 2022

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Dec 23, 2022

Description

This pull request enables Bepinex to use the latest Cpp2IL.

Motivation and Context

The new-analysis branch is legacy, and support has only been held for Bepinex. Switching would allow full focus on the development branch.

How Has This Been Tested?

It has not been tested, but similar code was used in AssetRipper.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Kasuromi
Kasuromi approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@Kasuromi Kasuromi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Runs without issue on GTFO (Unity 2019.4.21f1) and x86 TestGame (2021.3.4f1) - which previously had issues with initializing Cpp2IL

@Kasuromi Kasuromi merged commit 6aabdb5 into BepInEx:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kasuromi Kasuromi Kasuromi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ds5678 @Kasuromi