Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chainloader events #475

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

js6pak
Copy link
Member

@js6pak js6pak commented Aug 24, 2022

Adds events to chainloader to allow for library plugins to make apis like PluginSingleton or RegisterCustomRpcAttribute

Copy link
Contributor

@ghorsington ghorsington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to accept this now, but this is likely to change in future. Importantly:

  • Instead of just Action it's probably better to pass a proper EventHandler<T> in case parameters change in future
  • PluginLoad is in Il2Cpp but not in other runtimes that use the BasePlugin approach.

@ghorsington ghorsington merged commit 8b32f63 into BepInEx:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants