Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version #390

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Bump version #390

merged 3 commits into from
Mar 12, 2020

Conversation

jaydenmilne
Copy link
Contributor

This PR is because we've started using type annotations in a few places, which require python >=3.5. If we feel we really need to support lower versions we don't have to make this change.

Fixed a couple docs typos too.

daniekpo
daniekpo approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@daniekpo daniekpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

vinhowe
vinhowe approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@vinhowe vinhowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

MaxRobinsonTheGreat
MaxRobinsonTheGreat approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@MaxRobinsonTheGreat MaxRobinsonTheGreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaydenmilne jaydenmilne merged commit a63fc9b into develop Mar 12, 2020
@jaydenmilne jaydenmilne deleted the bump-version branch March 12, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinhowe vinhowe vinhowe approved these changes

@daniekpo daniekpo daniekpo approved these changes

@MaxRobinsonTheGreat MaxRobinsonTheGreat MaxRobinsonTheGreat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaydenmilne @MaxRobinsonTheGreat @daniekpo @vinhowe