Skip to content

Conversation

@jrjrguo
Copy link
Member

@jrjrguo jrjrguo commented Dec 11, 2025

Pull latest typespec changes, which fixed some documentation issues.
Update documentations for v2 and update links to latest translator sites.
Fix an issue where TextTranslationClientBuilderExtensions was generated as a separate TranslationTextClientBuilderExtensions that was messed up during codegen renaming.

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.AI.Translation.Text

@jrjrguo jrjrguo marked this pull request as ready for review December 11, 2025 23:51
@jrjrguo jrjrguo requested a review from SG-MS as a code owner December 11, 2025 23:51
Copilot AI review requested due to automatic review settings December 11, 2025 23:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Text Translation SDK by pulling the latest TypeSpec changes, fixing documentation issues, updating links, and resolving a code generation naming issue.

Key changes:

  • Corrects spelling errors in XML documentation comments ("interger" → "integer")
  • Fixes CodeGenType attribute to prevent duplicate class generation issue with TextTranslationClientBuilderExtensions
  • Updates documentation links from v3-0 references to the latest preview API documentation

Reviewed changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Updates TypeSpec commit reference to pull latest changes
TranslationTextModelFactory.cs Corrects spelling of "integer" in XML documentation
TranslationText.cs Corrects spelling of "integer" in XML documentation
TextTranslationClientBuilderExtensions.cs (Generated) Removes duplicate/incorrect methods and fixes class naming
TextTranslationClientBuilderExtensions.cs (Custom) Fixes CodeGenType attribute to resolve duplicate class generation
Sample2_TranslateAsync.md Removes outdated profanity handling link
Sample2_Translate.md Removes outdated profanity handling link
Sample0_CreateClient.md Updates links to new Azure AI services documentation
Azure.AI.Translation.Text.netstandard2.0.cs Updates API surface to remove duplicate class
Azure.AI.Translation.Text.net8.0.cs Updates API surface and RequiresDynamicCode message
Azure.AI.Translation.Text.net10.0.cs New API file for .NET 10.0 target
README.md Enhances descriptions and updates documentation links

Copy link
Member

@SG-MS SG-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jrjrguo jrjrguo merged commit 207e99d into Azure:main Dec 16, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants