Add MaxPageSizeParameterVisitor to rename maxpagesize parameter to camelCase #54469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
maxpagesizeparameter from Azure.Core TypeSpec models needs camelCase formatting (maxPageSize) in generated C# code to follow naming conventions.Implementation Status: Work in Progress
This PR adds the infrastructure for parameter renaming but the visitor implementation is not yet functional. The generated code still produces
_maxpagesizeinstead of_maxPageSizefor field names.Changes Made
MaxPageSizeParameterVisitor: Visitor that detectsmaxpagesizeparameters and attempts to create newInputMethodParameterandInputQueryParameterobjects withName="maxPageSize"while preservingSerializedName="maxpagesize"for wire formatmaxPageSizein generated collection result definitionsAzureClientGeneratorvisitor pipeline early in execution orderKnown Issue
The
InputServiceMethod.Update(parameters:)call does not propagate parameter name changes to generated code. Field names inCollectionResultDefinitioncontinue using the original parameter name.Possible causes under investigation:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.