-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Prepare Azure.Provisioning.AppContainers for API version 2025-01-01 regeneration #54393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…7-01 Co-authored-by: ArcturusZhang <[email protected]>
ArcturusZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please resolve other comments first.
Important:
This Azure.Provisioning.AppContainers is generated therefore no code should be manually changed. Everything of this package should be generated.
Please just run the generation command in your context to get the library updated, and then check if in the generated changes we have those changes in the original issue.
…iners to 1.6.0-alpha.20251208.1 Co-authored-by: ArcturusZhang <[email protected]>
I've reverted the Generator.csproj to use PackageReference and updated eng/Packages.Data.props to version 1.6.0-alpha.20251208.1 (commit 7cdacb2). However, I'm unable to run the generation command because it requires Azure credentials to query ARM for API versions. The generator uses Could you either:
|
ArcturusZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please resolve the comments
Co-authored-by: ArcturusZhang <[email protected]>
Description
Prepares the infrastructure for regenerating Azure.Provisioning.AppContainers with updated API version support, which will enable newer features for Container Apps.
Changes:
Azure.ResourceManager.AppContainersversion ineng/Packages.Data.propsfrom1.4.0to1.5.0(latest stable version with API version 2025-01-01 support)Generator.csprojto usePackageReferenceinstead ofProjectReferenceas per code review feedbackNote: The provisioning library generation requires Azure credentials to query ARM for supported API versions. Once the generator is run with appropriate credentials, it will regenerate the Azure.Provisioning.AppContainers library with the API versions supported by Azure.ResourceManager.AppContainers 1.5.0.
Expected Usage After Generation:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.