we cannot reverse open generics with ForPath because ForPath doesn't work with strings

lbargaoanu · lbargaoanu · commit a726f0914849 · 2023-01-03T08:29:51.000+02:00
diff --git a/src/AutoMapper/Configuration/TypeMapConfiguration.cs b/src/AutoMapper/Configuration/TypeMapConfiguration.cs
@@ -104,7 +104,10 @@ private void AddValueTransformers(TypeMap typeMap)
     }
     private void ConfigureReverseMap(TypeMap typeMap)
     {
-        ReverseSourceMembers(typeMap);
+        if (!typeMap.Types.ContainsGenericParameters)
+        {
+            ReverseSourceMembers(typeMap);
+        }
         foreach (var destProperty in typeMap.PropertyMaps.Where(pm => pm.Ignored))
         {
             ReverseMapExpression.ForSourceMemberCore(destProperty.DestinationName, opt => opt.DoNotValidate());
diff --git a/src/UnitTests/OpenGenerics.cs b/src/UnitTests/OpenGenerics.cs
@@ -1,4 +1,40 @@
 &#65279;namespace AutoMapper.UnitTests;
+public class ForPathGenericsSource : AutoMapperSpecBase
+{
+    class Source<T>
+    {
+        public InnerSource Inner;
+    }
+    class InnerSource
+    {
+        public int Id;
+    }
+    class Destination
+    {
+        public int InnerId;
+    }
+    protected override MapperConfiguration CreateConfiguration() => new(c => c.CreateMap(typeof(Source<>), typeof(Destination)).ReverseMap());
+    [Fact]
+    public void Should_work() => Map<Destination>(new Source<int> { Inner = new() { Id = 42 } }).InnerId.ShouldBe(42);
+}
+public class ForPathGenerics : AutoMapperSpecBase
+{
+    class Source<T>
+    {
+        public InnerSource Inner;
+    }
+    class InnerSource
+    {
+        public int Id;
+    }
+    class Destination<T>
+    {
+        public int InnerId;
+    }
+    protected override MapperConfiguration CreateConfiguration() => new(c => c.CreateMap(typeof(Source<>), typeof(Destination<>)).ReverseMap());
+    [Fact]
+    public void Should_work() => Map<Destination<int>>(new Source<int> { Inner = new() { Id = 42 } }).InnerId.ShouldBe(42);
+}
 public class ReadonlyPropertiesGenerics : AutoMapperSpecBase
 {
     class Source

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,10 @@ private void AddValueTransformers(TypeMap typeMap)`
`104`	`104`	`}`
`105`	`105`	`private void ConfigureReverseMap(TypeMap typeMap)`
`106`	`106`	`{`
`107`		`- ReverseSourceMembers(typeMap);`
	`107`	`+ if (!typeMap.Types.ContainsGenericParameters)`
	`108`	`+ {`
	`109`	`+ ReverseSourceMembers(typeMap);`
	`110`	`+ }`
`108`	`111`	`foreach (var destProperty in typeMap.PropertyMaps.Where(pm => pm.Ignored))`
`109`	`112`	`{`
`110`	`113`	`ReverseMapExpression.ForSourceMemberCore(destProperty.DestinationName, opt => opt.DoNotValidate());`