Skip to content

Commit c7dd02c

Browse files
sis0k0Alexander Vakrilov
authored andcommitted
docs: update the PR template to suggest following the commit message guidelines (NativeScript#5436)
1 parent 625d801 commit c7dd02c

File tree

1 file changed

+33
-8
lines changed

1 file changed

+33
-8
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,37 @@
1-
To help the rest of the community review your change, please ensure:
1+
<!--
2+
We, the rest of the NativeScript community, thank you for your
3+
contribution!
4+
To help the rest of the community review your change, please follow the instructions in the template.
5+
-->
26

3-
### PR has a meaningful title
4-
A good title is less than 50 characters and starts with a capital
5-
letter, similar to a good [Git Commit Message] (http://chris.beams.io/posts/git-commit/).
7+
<!-- PULL REQUEST TEMPLATE -->
8+
<!-- (Update "[ ]" to "[x]" to check a box) -->
69

7-
### The commit message references a specific issue in this repo
8-
Fixes/Implements #[Issue Number].
10+
## PR Checklist
911

10-
### You have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md)
11-
if appropriate.
12+
- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
13+
- [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
14+
- [ ] You have signed the [CLA](http://www.nativescript.org/cla).
15+
- [ ] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
16+
- [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.
17+
18+
## What is the current behavior?
19+
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
20+
21+
## What is the new behavior?
22+
<!-- Describe the changes. -->
23+
24+
Fixes/Implements/Closes #[Issue Number].
25+
26+
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
27+
28+
<!--
29+
BREAKING CHANGES:
30+
31+
32+
[Describe the impact of the changes here.]
33+
34+
Migration steps:
35+
[Provide a migration path for existing applications.]
36+
-->
1237

0 commit comments

Comments
 (0)