fix(ios-frame): do not update backstack when navigating the same page (NativeScript#5426)

ADjenkov · web-flow · commit 714af6bb0281 · 2018-02-19T11:53:04.000+02:00
diff --git a/tns-core-modules/ui/frame/frame.ios.ts b/tns-core-modules/ui/frame/frame.ios.ts
@@ -37,6 +37,14 @@ export class Frame extends FrameBase {
         return this._ios;
     }
 
+    public setCurrent(entry: BackstackEntry, isBack: boolean): void {
+        if (entry !== this._currentEntry) {
+            this._updateBackstack(entry, isBack);
+        }
+
+        super.setCurrent(entry, isBack);
+    }
+
     @profile
     public _navigateCore(backstackEntry: BackstackEntry) {
         super._navigateCore(backstackEntry);
@@ -352,7 +360,7 @@ class UINavigationControllerImpl extends UINavigationController {
 
     @profile
     public viewDidDisappear(animated: boolean): void {
-        super.viewDidDisappear(animated);    
+        super.viewDidDisappear(animated);
         const owner = this._owner.get();
         if (owner && owner.isLoaded && !owner.parent && !this.presentedViewController) {
             owner.callUnloaded();
diff --git a/tns-core-modules/ui/page/page.ios.ts b/tns-core-modules/ui/page/page.ios.ts
@@ -138,7 +138,6 @@ class UIViewControllerImpl extends UIViewController {
                 isBack = isBackNavigationTo(owner, newEntry);
             }
 
-            frame._updateBackstack(newEntry, isBack);
             frame.setCurrent(newEntry, isBack);
 
             // If page was shown with custom animation - we need to set the navigationController.delegate to the animatedDelegate.

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,6 @@ class UIViewControllerImpl extends UIViewController {`
`138`	`138`	`isBack = isBackNavigationTo(owner, newEntry);`
`139`	`139`	`}`
`140`	`140`
`141`		`- frame._updateBackstack(newEntry, isBack);`
`142`	`141`	`frame.setCurrent(newEntry, isBack);`
`143`	`142`
`144`	`143`	`// If page was shown with custom animation - we need to set the navigationController.delegate to the animatedDelegate.`