Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker container crashes if Github is not available #51

Closed
reconman opened this issue May 5, 2022 · 1 comment
Closed

Docker container crashes if Github is not available #51

reconman opened this issue May 5, 2022 · 1 comment

Comments

@reconman
Copy link
Collaborator

reconman commented May 5, 2022

Github was not available for a short time and the Alerthub Docker container repeatedly crashed with this exception:

Node.js v18.0.0
Application booted at Thu, 05 May 2022 08:22:55 GMT
node:events:505
      throw er; // Unhandled 'error' event
      ^

fetch_url_error: Cannot connect to https://www.github.com/gematik/api-ePA/commits/master.atom
    at Request.<anonymous> (/usr/src/app/node_modules/rss-feed-emitter/src/Feed.js:192:26)
    at Request.emit (node:events:539:35)
    at Request.onRequestError (/usr/src/app/node_modules/request/request.js:877:8)
    at ClientRequest.emit (node:events:527:28)
    at TLSSocket.socketErrorListener (node:_http_client:454:9)
    at TLSSocket.emit (node:events:527:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
Emitted 'error' event on FeedEmitter instance at:
    at FeedManager.onError (/usr/src/app/node_modules/rss-feed-emitter/src/FeedManager.js:99:19)
    at Feed.handleError (/usr/src/app/node_modules/rss-feed-emitter/src/Feed.js:205:20)
    at Request.<anonymous> (/usr/src/app/node_modules/rss-feed-emitter/src/Feed.js:192:14)
    at Request.emit (node:events:539:35)
    [... lines matching original stack trace ...]
    at emitErrorCloseNT (node:internal/streams/destroy:116:3) {
  feed: 'https://www.github.com/gematik/api-ePA/commits/master.atom'
}

Instead, the application should log the error and continue running.
@Ardakilic
Copy link
Owner

Hello, apologies for the late reply. Totally missed this out. I was changing jobs by that time.

Just released a new version, it addresses the issue and should be fixed.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ardakilic @reconman