Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 'Back button opens drawer' if Bottom menu is enabled #7585

Closed
4 tasks done
keunes opened this issue Jan 1, 2025 · 0 comments · Fixed by #7595
Closed
4 tasks done

Disable 'Back button opens drawer' if Bottom menu is enabled #7585

keunes opened this issue Jan 1, 2025 · 0 comments · Fixed by #7595
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one

Comments

@keunes
Copy link
Member

keunes commented Jan 1, 2025

Checklist

  • I have used the search function for OPEN issues to see if someone else has already submitted the same feature request.
  • I have also used the search function for CLOSED issues to see if the feature was already implemented and is just waiting to be released, or if the feature was rejected.
  • I will describe the problem with as much detail as possible.
  • This request contains only one single feature, not a list of multiple (related) features.

App version

3.6.0

Feature or improvement you want

If the setting 'Bottom navigation' is enabled, the setting 'Back button opens drawer' should be greyed out.

Why should this be added?

If 'Bottom navigation' is enabled, the side menu doesn't open when pressing the back button, even if the other setting is enabled. That's a little confusing.

Screenshots / Drawings / Technical details

As shared here: https://chaos.social/@Schaarsen/113753113136219459
@keunes keunes added the Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one label Jan 1, 2025
@ByteHamster ByteHamster added the Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed label Jan 1, 2025
@winkelnp winkelnp mentioned this issue Jan 4, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Can be addressed without deep knowledge of the AntennaPod code. But exploring the code may be needed Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable 'Back button opens drawer' if Bottom menu is enabled winkelnp/AntennaPod
2 participants
@ByteHamster @keunes