-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to the media3 library #6608
Comments
Seeing this makes me very happy.
If you look at the ExoPlayer changelog, I think you'll get use out of this:
There's some other stuff in the ExoPlayer releases that I think could be used, too. Be sure to take advantage of any new features (like the above). Here's some other resources:
|
I already played around with this in https://github.com/ByteHamster/AntennaPod/tree/media3. This is an insane amount of work and requires completely re-writing our playback service. Incremental version updates probably won't help because the entire playback code needs to be thrown away anyway. My very minimalistic re-write that doesn't support any features except the "play" button (no speed, no position saving, etc) still does not fix #6576. So I'm pretty sure that upgrading to media3 will not directly solve any of the issues we currently have, but will cause us a bunch of new issues. So this rewrite is quite low on my list currently. |
I can take a stab at this. As a preliminary warning, however, I think this would involve redesigning (and rewriting) many components, so it is quite a major change that would require more discussions. Will this Github issue be an appropriate venue for such discussions? |
Regarding #6576 (sorry, I'm not allowed to comment there): I have a good understanding on what's happening there. I think the media session API is just not designed to handle resuming playback from the notification when the playback service is evicted. Upgrading to media3 should actually help there, if we let it take care of the service lifecycle and notifications. |
Personally I prefer the forum for long/difficult discussions because it's a bit better suited for it (quoting etc). However, if there's no changes affecting the UI/UX, it's fine to do it here I guess. |
I would say so, yes. It's mainly a technical discussion and doesn't need UI decisions. I guess discussing code in the PR would also be a big part of this.
Yes, that's what I thought as well when playing around with media3 a bit. Given that the playback service is, by far, the most complex part of AntennaPod, I think it is worth the rewrite. (Some years ago I rewrote the download service, which helped a lot with making it more maintainable. I even deleted like half of the code while keeping the same functionality. I assume it could be similar for the playback service) |
@ByteHamster would it be possible to unlock #6576 so that I can chime in on the matter of the service being destroyed when media is paused, resulting in the play button not working from the notification? I don't want to post about it here, given that I don't think |
Checklist
App version
3.1.0
Where did you get the app from
Google Play
Problem you may be having, or feature you want
There are some issues with the notifications when playback is paused. They are most likely resolved with upgrading to the media3 library.
Suggested solution
Upgrade to the media3 library :D
Screenshots / Drawings / Technical details
Blocked by #6601.
Resolving this probably also closes #6576.
Media3 introduction: https://developer.android.com/guide/topics/media/media3
Migration guide: https://developer.android.com/guide/topics/media/media3/getting-started/migration-guide (there even is a migration script)
The text was updated successfully, but these errors were encountered: