Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade 'New' screen to 'Inbox' #5267

Closed
6 tasks
keunes opened this issue Jul 11, 2021 · 10 comments
Closed
6 tasks

Upgrade 'New' screen to 'Inbox' #5267

keunes opened this issue Jul 11, 2021 · 10 comments
Labels
Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one

Comments

@keunes
Copy link
Member

keunes commented Jul 11, 2021 •
edited
Loading

Checklist

  • [x ] I have used the search function to see if someone else has already submitted the same feature request.
  • [x ] I will only create one feature request per issue.
  • [x ] I will describe the problem with as much detail as possible.

System info

App version: 2.3.0-beta3

App source: Google Play

Feature description

Problem you may be having, or feature you want:
As described on the forum, swiping episodes in the 'All' tab of the ‘Episodes’ screen is limited (because swiping changes tabs) and ambiguous (the it's not clear what swiping does).

Also, I would like to have a single place where I can select if I want my episode to be added to the queue or ignored.

Suggested solution:

Screenshots / Drawings / Technical details:

  • elevate the 'New' tab of the Episodes screen into a separate 'Inbox' screen
  • make sure the following swipe actions from Swipe actions #5191 are available,
    that they fully swipe away (removing the episode from the list, contrary to the 'half swipe' in most other screens)
    display the 'settings' dialog when swiping for the first time
    where 'remove from inbox' is the default setting for left swipe
    where 'add to queue' is the default setting for right swipe
    where the icons and colours are as indicated in issue referenced above
    • Add to queue
    • Mark as favorite
    • Download
    • Ignore
    • Remove from Inbox
  • Replace the 'New' text label by the inbox icon and update the colour to #007FFF
  • Replace the Remove "new" flag item in the episode long-press menu with Remove from Inbox, and make it remove items from the Inbox
  • make sure that when an episode is interacted with by the user (= manually downloaded, manually added to the queue, or set to ignored), it is removed from the inbox
  • under 'Settings' > 'Network' > 'Automatic download', add a setting Exclude episodes still in my Inbox (and prevent auto-download from considering episodes that are still in the inbox, if the setting is active)

For screenshots, please see the forum thread linked above :)
@keunes keunes added the Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one label Jul 11, 2021
@ByteHamster
Copy link
Member

under 'Settings' > 'Network' > 'Automatic download', add a setting Exclude episodes still in my Inbox (and prevent auto-download from considering episodes that are still in the inbox, if the setting is active)

Actually, we currently only consider episodes that are marked as new (or in the queue) for auto-download. So that setting would basically disable auto-download.

@keunes
Copy link
Member Author

keunes commented Jul 11, 2021 •
edited
Loading

Huh, ok, didn't realise. For me, with the Inbox enabled, I would expect (only) the following episodes to be auto-downloaded:

  • are 'Removed from Inbox' (but not ignored), and
  • are added to the queue (but not downloaded yet)

Not sure: could this already be addressed with the Inbox, or is it better updated together with all other Auto-download/delete mess?

@ByteHamster
Copy link
Member

Not sure: could this already be addressed with the Inbox, or is it better updated together with all other Auto-download/delete mess?

I would do it with the other auto-download stuff.

For me, with the Inbox enabled, I would expect (only) the following episodes to be auto-downloaded

Doesn't that mean it's no longer automatic? You then have to perform an action if you want episodes to be auto-downloaded. Currently, I can just enable auto-download for my favorite subscriptions and their items will be downloaded and go directly to the queue without me having to do anything. For me, that is the main point of auto-download - not having to do anything before.

This was referenced Aug 4, 2021
Closed
Open
@keunes keunes mentioned this issue Oct 5, 2021
Closed
3 tasks
@keunes keunes mentioned this issue Dec 14, 2021
Closed
3 tasks
@keunes keunes mentioned this issue Dec 29, 2021
Closed
@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/mark-episode-s-as-new-filter-on-new-episodes/1683/2

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/mark-episode-s-as-new-filter-on-new-episodes/1683/3

@keunes
Copy link
Member Author

keunes commented Feb 18, 2022 •
edited
Loading

Doesn't that mean it's no longer automatic? You then have to perform an action if you want episodes to be auto-downloaded.

It would be semi-automatic: it auto-downloads from a pool of episodes I am interested in. Given the amount of podcasts I am subscribed to, auto download will have many 'approved' podcasts to choose from.
Let's turn it around: why waste storage & (mobile) data for auto-downloading of episodes there's a chance I am not interested in (and would delete again when I come across them)?

If you are not subscribed to many podcasts, or you do not want to manually review the new episodes the inbox is not relevant for you. In that case I think it makes sense to have a 'switch off inbox' option. And when the inbox is not used, auto-download indeed would consider new & unplayed episodes.

@ByteHamster
Copy link
Member

when the inbox is not used, auto-download indeed would consider new & unplayed episodes.

To me, that sounds like it should be an option for the auto-download behavior, not an option for turning off the inbox.

@keunes
Copy link
Member Author

keunes commented Feb 18, 2022

To me, that sounds like it should be an option for the auto-download behavior, not an option for turning off the inbox.

For me it made sense to couple the two, but a separate setting for auto-download would work nicely as well.

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/inbox-looking-for-testers/1918/1

@ByteHamster
Copy link
Member

All done, except the auto-download change. That's something I would do when reworking the auto-download feature. Will be released in 2.7.0

@keunes keunes mentioned this issue May 3, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature request Issues which request the introduction of a new feature or improvement/enhancement of an existing one
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ByteHamster @keunes @antennapod-bot