Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscriptions to tags/folders #4634

Merged
merged 26 commits into from
Mar 5, 2021
Merged

Add subscriptions to tags/folders #4634

merged 26 commits into from
Mar 5, 2021

Conversation

ByteHamster
Copy link
Member

@ByteHamster ByteHamster commented Nov 2, 2020

I initiated work on this but I do not think that I will bring the folder support to completion if nobody helps. If you want folder support to become reality, create a pull request for this branch. This proof-of-concept should make it easier to get started and help implementing the feature gradually instead of having to do everything at once.

  • Subscriptions page crashes
  • Sum up the counters of folders
  • When scrolling quickly, folders sometimes get feed icons. Cancel glide loading when sharing ViewHolders
  • Are layers only needed in the drawer, not the subscriptions screen? If so, move layer calculation to the drawer when making the flat list.
  • Drawer items without a counter do not fill the whole width
  • Add "tags" column to feed database table and store a list of folders (strings, separated by some nice ascii character like record separator)
  • Add tags property to feed class
  • Build folder list based on the tags property (can also just assign some tags before building as a proof-of-concept, no need for real tags from the database)
  • Assign valid (and unique) item IDs to folders and items. This kind-of works but some animations are still broken.
  • Long-pressing folders crashes
  • Fix highlighting drawer items
  • Sort folders to the end of the sidebar
  • Store open folders across app launches
  • Make layer depth dependent on dp instead of just assigning some pixel based padding. Maybe align images with the text from the parent folder?
  • Show tags on top of the subscriptions screen (Allow applying tags to podcasts or putting them into groups/folders/categories #1711 (comment)) Postponed. Someone else should do that.
  • Add nice UI for managing tags of a subscription (eg something like the new playback speed dialog with chips) It works but it's not nice. Someone else should do that.

Closes #1711

@tonytamsf
Copy link
Member

tonytamsf commented Nov 2, 2020

Thanks for starting this, can you change the PR title to add the words collaborate or swarm, co-working.

@ByteHamster ByteHamster changed the title Add subscriptions to tags/folders Add subscriptions to tags/folders (looking for contributors) Nov 3, 2020
@tonytamsf
Copy link
Member

Thank you for starting this, I hope I can help, but I don't feel strongly about this feature to work on it

@antennapod-bot
Copy link

This pull request has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/podcasts-grouping/491/2

@ByteHamster ByteHamster marked this pull request as ready for review January 2, 2021 16:31
@antennapod-bot
Copy link

This pull request has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/add-podcast-subscriptions-categories-tags/594/2

@ByteHamster ByteHamster changed the title Add subscriptions to tags/folders (looking for contributors) Add subscriptions to tags/folders Mar 5, 2021
@ByteHamster ByteHamster merged commit dd0502c into develop Mar 5, 2021
@ByteHamster ByteHamster deleted the folders branch March 5, 2021 16:18
@antennapod-bot
Copy link

This pull request has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/antennapod-2-3-0-release-notes/1047/1

@keunes keunes mentioned this pull request Jul 12, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow applying tags to podcasts or putting them into groups/folders/categories
3 participants