Add column major input support in contractions_nt kernels with new kernel policy for it #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@teju85 for help with review. |
cjnolet
added
improvement
…olumn_major_contractions_nt
|
@divyegala please help with review. |
|
Thank you Divye! I guess since this is Mahesh's first PR to raft, this requires a whitelisting from the admin team? @JohnZed ? |
|
rerun tests |
|
ok to test |
|
@teju85 is this PR now good to merge? Who can merge it? |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Apr 9, 2021
…nstead of cutlass (#3691) This change depends on RAFT pull request - rapidsai/raft#188 -- Adds column major input support in prims_benchmark's Distance bench -- Removes cutlass from all distance metrics in column major case. -- Removes cutlass from all the distance metrics test cases. Authors: - Mahesh Doijade (https://github.com/mdoijade) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Thejaswi. N. S (https://github.com/teju85) URL: #3691
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…nstead of cutlass (rapidsai#3691) This change depends on RAFT pull request - rapidsai/raft#188 -- Adds column major input support in prims_benchmark's Distance bench -- Removes cutlass from all distance metrics in column major case. -- Removes cutlass from all the distance metrics test cases. Authors: - Mahesh Doijade (https://github.com/mdoijade) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Thejaswi. N. S (https://github.com/teju85) URL: rapidsai#3691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.