Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Scaling knn graph fix connectivities algorithm #181

Merged
merged 31 commits into from
Mar 26, 2021
Merged

[REVIEW] Scaling knn graph fix connectivities algorithm #181

merged 31 commits into from
Mar 26, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 24, 2021

This PR reduces unecessary memory usage while connecting a KNN graph by normalizing colors so they are drawn from a monotonically increasing set.

@cjnolet cjnolet added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 25, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Mar 25, 2021

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Mar 25, 2021

rerun tests

@cjnolet cjnolet changed the title [WIP] Scaling knn graph fix connectivities algorithm [REVIEW] Scaling knn graph fix connectivities algorithm Mar 26, 2021
@dantegd dantegd mentioned this pull request Mar 26, 2021
Merged
divyegala
divyegala requested changes Mar 26, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and mostly small comments/questions! Happy to iterate on this today and get it in before the weekend

cpp/include/raft/label/classlabels.cuh Outdated Show resolved Hide resolved
cpp/include/raft/label/classlabels.cuh Outdated Show resolved Hide resolved
cpp/include/raft/label/classlabels.cuh Show resolved Hide resolved
cpp/include/raft/label/classlabels.cuh Show resolved Hide resolved
cpp/include/raft/label/classlabels.cuh Show resolved Hide resolved
cpp/include/raft/label/merge_labels.cuh Show resolved Hide resolved
cpp/include/raft/label/merge_labels.cuh Outdated Show resolved Hide resolved
cpp/include/raft/linalg/init.h Show resolved Hide resolved
cpp/include/raft/sparse/op/reduce.cuh Show resolved Hide resolved
cpp/include/raft/sparse/op/sort.h Outdated Show resolved Hide resolved
divyegala
divyegala approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since we are trying to get this code copied over from cuML for SLHC to make 0.19. May target cleanup in 0.20. Thanks, Corey!

@dantegd
Copy link
Member

dantegd commented Mar 26, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d7077d7 into rapidsai:branch-0.19 Mar 26, 2021
@divyegala divyegala mentioned this pull request Jul 16, 2021
Closed
dantegd pushed a commit to dantegd/raft that referenced this pull request Jul 23, 2024
@achirkin
Scaling workspace resources (rapidsai#181)
5668ef0 
Use raft's large workspace resource for large temporary allocations during ANN index build.
This is the port of rapidsai#2194, which didn't make into raft before the algorithms were ported to cuVS.

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)

URL: rapidsai/cuvs#181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @dantegd @divyegala