Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fixing RAFT CI & a few small updates for SLHC Python wrapper #178

Merged
merged 10 commits into from
Mar 24, 2021
Merged

[REVIEW] Fixing RAFT CI & a few small updates for SLHC Python wrapper #178

merged 10 commits into from
Mar 24, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 22, 2021

No description provided.

@cjnolet cjnolet added bug Something isn't working improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 2 - In Progress Currenty a work in progress cpp enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Mar 22, 2021
@cjnolet cjnolet mentioned this pull request Mar 22, 2021
Merged
viclafargue
viclafargue approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this fix Corey. This looks good! Just have two little question/comment.

cpp/test/sparse/linkage.cu Show resolved Hide resolved
cpp/test/sparse/linkage.cu Show resolved Hide resolved
@viclafargue
Copy link
Contributor

viclafargue commented Mar 23, 2021 •
edited
Loading

@rapidsai/ops One of the builds on this PR seems to have timed out during testing : Build timed out (after 40 minutes). Marking the build as failed.. Would it be possible to increase the allocated time? There's actually a problem with either the tests, the dependencies, or potentially one of the CI containers. We are investigating.

@cjnolet
Copy link
Member Author

cjnolet commented Mar 23, 2021

@viclafargue thanks for the fast review! I tagged you offline about the timeout. Our tests are very small and none of them should be timing out.

@cjnolet cjnolet added 3 - Ready for Review and removed 2 - In Progress Currenty a work in progress labels Mar 23, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Mar 23, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 23, 2021

@gpucibot merge

@cjnolet cjnolet mentioned this pull request Mar 23, 2021
Merged
@github-actions github-actions bot added the CMake label Mar 23, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Mar 23, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Mar 23, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit d076399 into rapidsai:branch-0.19 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

@viclafargue viclafargue viclafargue approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjnolet @viclafargue @dantegd @afender