[Review] Enable matrix::copyRows for row major input #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfeher
added
3 - Ready for Review
improvement
|
rerun tests |
cjnolet
approved these changes
Mar 23, 2021
|
@tfeher, I just merged branch-0.19 into your branch in hopes maybe CI wasn't seeing some of the recent changes. I'm still at a loss for why these hangs are occurring in CI. |
|
rerun tests |
|
The failures appear to be related to whether a P100 is selected as the CI machine. I notice the tests never timeout when a V100 or A100 is selected. |
|
rerun tests |
|
@gpucibot merge |
dantegd
pushed a commit
to dantegd/raft
that referenced
this pull request
Jul 23, 2024
Forward-merge branch-24.06 into branch-24.08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable matrix::copyRows operation for row_major input. This will be used in SVM to enable row major input rapidsai/cuml#2198
We use a helper function prim
cache:get_vecs()from cuML. Because of this, the cache_util.cuh file is copied to raft (only the namespace is updated). A separate PR shall update the the rest of the cache function and the associated tests and move it to RAFT.