Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dice distance to distancetype enum #174

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Add Dice distance to distancetype enum #174

merged 4 commits into from
Mar 24, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Mar 18, 2021

Very small change to include Dice in the DistanceType enum

@github-actions github-actions bot added the cpp label Mar 18, 2021
@lowener lowener added the non-breaking Non-breaking change label Mar 18, 2021
@lowener lowener requested a review from cjnolet March 23, 2021 15:29
cjnolet
cjnolet approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Mar 24, 2021

@gpucibot merge

@cjnolet
Copy link
Member

cjnolet commented Mar 24, 2021

rerun tests

@cjnolet cjnolet added 5 - Ready to Merge enhancement New feature or request improvement Improvement / enhancement to an existing function and removed 3 - Ready for Review enhancement New feature or request labels Mar 24, 2021
@cjnolet
Copy link
Member

cjnolet commented Mar 24, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8f447e2 into rapidsai:branch-0.19 Mar 24, 2021
@lowener lowener deleted the 019-dice-dist branch March 28, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lowener @cjnolet