Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update KNN #171

Merged
merged 4 commits into from
Mar 17, 2021
Merged

[REVIEW] Update KNN #171

merged 4 commits into from
Mar 17, 2021

Conversation

viclafargue
Copy link
Contributor

This PR updates the bruteforce KNN algorithm.

@github-actions github-actions bot added the cpp label Mar 15, 2021
@viclafargue viclafargue added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 15, 2021
@viclafargue viclafargue mentioned this pull request Mar 15, 2021
Merged
cjnolet
cjnolet requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, just one minor thing related to organization

cpp/include/raft/spatial/knn/detail/brute_force_knn.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CMake label Mar 16, 2021
cjnolet
cjnolet approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ready to go pending small merge conflict

@cjnolet cjnolet merged commit 7091ae3 into rapidsai:branch-0.19 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viclafargue @cjnolet