Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Adding translations parameter to brute_force_knn #170

Merged
merged 1 commit into from
Mar 11, 2021
Merged

[REVIEW] Adding translations parameter to brute_force_knn #170

merged 1 commit into from
Mar 11, 2021

Conversation

viclafargue
Copy link
Contributor

This PR adds the translations parameter to brute_force_knn. It is required for PR cuml:#3603.

@github-actions github-actions bot added the cpp label Mar 11, 2021
@cjnolet cjnolet added enhancement New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2021
cjnolet
cjnolet approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet merged commit 68ef1e1 into rapidsai:branch-0.19 Mar 11, 2021
@tfeher tfeher mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
cpp enhancement New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viclafargue @cjnolet