Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Map operation #168

Merged
merged 2 commits into from
Mar 12, 2021
Merged

[REVIEW] Map operation #168

merged 2 commits into from
Mar 12, 2021

Conversation

viclafargue
Copy link
Contributor

This PR adds a map operation. This can be useful when unary and binary operations are not enough.

@github-actions github-actions bot added the cpp label Mar 8, 2021
@viclafargue viclafargue added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 8, 2021
@viclafargue viclafargue changed the title [WIP] Map operation [REVIEW] Map operation Mar 12, 2021
@viclafargue viclafargue added 3 - Ready for Review and removed 2 - In Progress Currenty a work in progress labels Mar 12, 2021
@github-actions github-actions bot added the CMake label Mar 12, 2021
@viclafargue viclafargue mentioned this pull request Mar 12, 2021
Merged
cjnolet
cjnolet approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If I understand the usage correctly, I would use this if I wanted to perform anything greater than a binary element-wise operation, right?

@cjnolet cjnolet merged commit 5ea9795 into rapidsai:branch-0.19 Mar 12, 2021
@viclafargue
Copy link
Contributor Author

LGTM. If I understand the usage correctly, I would use this if I wanted to perform anything greater than a binary element-wise operation, right?

Thanks for the review and merge! Exactly, that will be helpful in case you need more than two parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viclafargue @cjnolet