Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Updating sparse prims based on recent changes #166

Merged
merged 6 commits into from
Mar 4, 2021
Merged

[REVIEW] Updating sparse prims based on recent changes #166

merged 6 commits into from
Mar 4, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 3, 2021

Pulling soe of @lowener's recent changes over to RAFT

@github-actions github-actions bot added the cpp label Mar 3, 2021
@cjnolet cjnolet added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cpp labels Mar 3, 2021
@github-actions github-actions bot added the cpp label Mar 3, 2021
divyegala
divyegala approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments, otherwise LGTM! Pre-approving

cpp/include/raft/sparse/distance/l2_distance.cuh Outdated Show resolved Hide resolved
cpp/include/raft/sparse/distance/lp_distance.cuh Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Mar 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 479b99b into branch-0.19 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

Assignees

@divyegala divyegala

Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @dantegd @divyegala