Fix FakeRedisMixin.from_url for unix sockets #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmerry
requested changes
Aug 26, 2021
Collaborator
bmerry
left a comment
bmerry
left a comment
There was a problem hiding this comment.
Thanks. This looks good (assuming it passes the tests, which I've just kicked off) - can you just add a comment where you've added to _server.py to explain what the line is for.
fakeredis.FakeRedisMixin.from_url is broken for unix sockets.
fakeredis.FakeRedis.from_url("unix://a/b/c") results in
TypeError: __init__() got an unexpected keyword argument 'path'
This was caused by PR #304.
Contributor
Author
|
Thanks for the reply, I have added a comment. |
bmerry
approved these changes
Aug 27, 2021
Collaborator
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fakeredis.FakeRedisMixin.from_url is broken for unix sockets.
fakeredis.FakeRedis.from_url("unix://a/b/c") results in
TypeError: init() got an unexpected keyword argument 'path'
This was caused by PR #304.