fix(carousel): arrow keys break animation if carousel sliding #34307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
force-pushed
the
alpa/fix-carousel-arrow-navigation
branch
from
a47157a to
46e88ce
Compare
GeoSot
reviewed
Jun 20, 2021
…l is sliding fix(carousel): arrow keys break animation if carousel sliding
alpadev
force-pushed
the
alpa/fix-carousel-arrow-navigation
branch
from
46e88ce to
2f41139
Compare
GeoSot
approved these changes
Jun 21, 2021
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34290
Alternatively I guess we could remove those if conditions and add one to the_slidemethod but that would require changes to the tests as well.