Skip to content

fix(forms): unitless line-height for floating labels #34161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
XhmikosR merged 3 commits into from
Jun 3, 2021
Merged

fix(forms): unitless line-height for floating labels #34161

XhmikosR merged 3 commits into from
Jun 3, 2021

Conversation

@ffoodd
Copy link
Member

@ffoodd ffoodd commented Jun 1, 2021 •
edited
Loading

@ffoodd ffoodd requested a review from a team as a code owner June 1, 2021 12:50
mdo
mdo reviewed Jun 3, 2021
View reviewed changes
@alecpl
Copy link
Contributor

alecpl commented Jun 3, 2021

I confirm 1.25 works the same as 1.25rem in Firefox and Chromium.

@XhmikosR XhmikosR changed the title Floating control line-height fix(forms): unitless line-height for floating labels Jun 3, 2021
@XhmikosR XhmikosR merged commit dbda13d into main Jun 3, 2021
@XhmikosR XhmikosR deleted the main-fod-floating-select-line-height branch June 3, 2021 16:02
@mdo mdo mentioned this pull request Jun 14, 2021
Closed
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
@ffoodd @mdo
@XhmikosR @marvin-hinkley-vortx
fix(forms): unitless line-height for floating labels (twbs#34161)
600e24e 
Co-authored-by: Mark Otto <[email protected]>
Co-authored-by: XhmikosR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes

Assignees

No one assigned

Labels

css v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v5: Inputs and Selects are slightly misaligned in Floating Forms

5 participants

@ffoodd @alecpl @mdo @XhmikosR