Skip to content

Conversation

@simonihmig
Copy link
Contributor

A selectbox is styled in a very similar way as an input (.form-control), including border-color and box-shadow. So it can be assumed it should apply the same CSS transition for these properties when focused, but this was missing.

A selectbox is styled in a very similar way as an input (`.form-control`), including border-color and box-shadow. So it can be assumed it should apply the same CSS transition for these properties when focused, but this was missing.
@simonihmig simonihmig requested a review from a team as a code owner May 19, 2021 16:55
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, it exists in v4 and I don't know why it's been dropped in v5. @mdo any idea? Was it done on purpose, or simply forgotten while moving from .custom-select?

@alpadev alpadev merged commit 649c2bb into twbs:main May 28, 2021
@simonihmig simonihmig deleted the select-transition branch May 28, 2021 07:31
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
A selectbox is styled in a very similar way as an input (`.form-control`), including border-color and box-shadow. So it can be assumed it should apply the same CSS transition for these properties when focused, but this was missing.

Co-authored-by: alpadev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants