Don't add empty content holder when there is no content available #33982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
reviewed
May 14, 2021
XhmikosR
reviewed
May 14, 2021
rohit2sharma95
commented
May 14, 2021
rohit2sharma95
force-pushed
the
rs-popover-title
branch
from
d72a37b to
3bbe2fb
Compare
GeoSot
approved these changes
May 14, 2021
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
May 20, 2021
…bs#33982) * Remove content holder when there is no content * Add tests to check the removal of header/content Co-authored-by: XhmikosR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29127
Alternative to #29570
A popover should not have an empty header or body when the content is not available on the main element or in the configuration.