Utils: add getNextActiveElement helper function
#33608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
reviewed
Apr 12, 2021
GeoSot
force-pushed
the
gs-list_picker-helper
branch
2 times, most recently
from
a1b4e6e to
55006cf
Compare
XhmikosR
changed the title
pickFromList helper
alpadev
approved these changes
Apr 15, 2021
alpadev
reviewed
Apr 15, 2021
GeoSot
force-pushed
the
gs-list_picker-helper
branch
from
55006cf to
8016046
Compare
GeoSot
force-pushed
the
gs-list_picker-helper
branch
2 times, most recently
from
f83badd to
a53cb79
Compare
GeoSot
force-pushed
the
gs-list_picker-helper
branch
from
b74e09c to
c27a1c7
Compare
rohit2sharma95
approved these changes
May 14, 2021
Contributor
rohit2sharma95
left a comment
rohit2sharma95
left a comment
There was a problem hiding this comment.
Better pickFromList => getNextActiveElement 🤔
Good work @GeoSot
🛠️ 🧰
XhmikosR
reviewed
May 14, 2021
rohit2sharma95
changed the title
pickFromList helpergetNextActiveElement helper function
GeoSot
force-pushed
the
gs-list_picker-helper
branch
from
ba76e09 to
2ff9ede
Compare
… implementation through components
GeoSot
force-pushed
the
gs-list_picker-helper
branch
from
2ff9ede to
0807a55
Compare
marvin-hinkley-vortx
pushed a commit
to Vortx-Inc/bootstrap
that referenced
this pull request
May 20, 2021
… implementation through components (twbs#33608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use one helper for all list next|previous functionality and use it on dropdown.js & carousel.js