Skip to content

fix(theme-docs): prevent warning when global components missing #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamincanac merged 15 commits into from
Nov 18, 2020
Merged

fix(theme-docs): prevent warning when global components missing #542

benjamincanac merged 15 commits into from
Nov 18, 2020

Conversation

@benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Oct 6, 2020 •
edited
Loading

This PR will prevent the warning when loading missing components/global/ directory at the root.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac linked an issue Oct 6, 2020 that may be closed by this pull request
[@nuxt/content-theme-docs] Override default components #328
Closed
@benjamincanac benjamincanac changed the title Feat/components override feat: components override Oct 6, 2020
@benjamincanac benjamincanac changed the title feat: components override feat(theme-docs): components override Oct 6, 2020
@benjamincanac benjamincanac requested a review from atinux October 6, 2020 09:23
@benjamincanac benjamincanac marked this pull request as draft October 7, 2020 16:34
@benjamincanac
Copy link
Member Author

benjamincanac commented Oct 7, 2020

@atinux Waiting for the next release of @nuxt/components.

@atinux atinux mentioned this pull request Oct 8, 2020
Merged
@benjamincanac benjamincanac marked this pull request as ready for review October 8, 2020 15:59
@benjamincanac benjamincanac force-pushed the feat/components-override branch from 382de0a to 0512002 Compare October 12, 2020 13:54
@atinux atinux mentioned this pull request Oct 20, 2020
Closed
@benjamincanac benjamincanac mentioned this pull request Oct 22, 2020
Closed
This was linked to issues Oct 22, 2020
How Do I Edit the Footer (Built with Nuxt) Section #579
Closed
[@nuxt/content-theme-docs] move color mode switcher to app header #369
Closed
@danestves
Copy link

danestves commented Oct 23, 2020

Waiting for this release! It's important for my open source documentation, i need to put a custom Netlify logo in there 🤗 let us know when this is done

@nozomuikuta nozomuikuta mentioned this pull request Oct 26, 2020
Closed
@benjamincanac benjamincanac removed a link to an issue Nov 18, 2020
[@nuxt/content-theme-docs] Override default components #328
Closed
This was unlinked from issues Nov 18, 2020
[@nuxt/content-theme-docs] move color mode switcher to app header #369
Closed
How Do I Edit the Footer (Built with Nuxt) Section #579
Closed
@benjamincanac benjamincanac changed the title feat(theme-docs): components override feat(theme-docs): prevent warning when global components missing Nov 18, 2020
@benjamincanac benjamincanac changed the title feat(theme-docs): prevent warning when global components missing fix(theme-docs): prevent warning when global components missing Nov 18, 2020
@benjamincanac benjamincanac merged commit 1c84288 into dev Nov 18, 2020
@benjamincanac benjamincanac deleted the feat/components-override branch November 18, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atinux atinux atinux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjamincanac @danestves @atinux @pi0